fix(config): persist cost_currency setting across sessions#956
Closed
namezzb wants to merge 1 commit intoHmbown:mainfrom
Closed
fix(config): persist cost_currency setting across sessions#956namezzb wants to merge 1 commit intoHmbown:mainfrom
namezzb wants to merge 1 commit intoHmbown:mainfrom
Conversation
Support --save flag in `/config <key> <value>` so settings can be persisted to settings.toml. Add cost_currency to the interactive /config UI editor and to the show-value query path. Closes Hmbown#932
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Closed
Owner
Owner
|
Clean note after closing: #997 is the maintainer replacement. It replays the useful fix on current main and adds regression coverage for |
Hmbown
added a commit
that referenced
this pull request
May 7, 2026
Summary: - Let /config cost_currency cny --save persist the setting. - Show the live cost currency via /config cost_currency. - Add cost currency to the interactive config document and apply path. - Add regression tests for command persistence and config UI currency round-tripping. Test plan: - cargo test -p deepseek-tui config_command_cost_currency_save_persists_value --locked - cargo test -p deepseek-tui build_document_reflects_cost_currency_from_settings --locked - cargo test -p deepseek-tui session_only_apply_keeps_runtime_overrides_and_skips_reload --locked - cargo fmt --all -- --check - git diff --check Supersedes #956. Fixes #932.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--saveflag in/config <key> <value>so settings can be persisted to settings.toml (e.g./config cost_currency cny --save)cost_currencytoshow_single_setting()so/config cost_currencydisplays the current valueCostCurrencyValueenum and wire it into the interactive/configTUI editor so users can change it visuallyCloses #932
Test plan
cost_currency-specific tests pass (pricing, settings, UI footer)cargo checkcompiles cleanly with no warnings