Skip to content

Desktop: Native export#3188

Merged
timon-schelling merged 8 commits intomasterfrom
desktop-native-export
Oct 1, 2025
Merged

Desktop: Native export#3188
timon-schelling merged 8 commits intomasterfrom
desktop-native-export

Conversation

@timon-schelling
Copy link
Copy Markdown
Member

@timon-schelling timon-schelling commented Sep 17, 2025

Needs #3194

Closes #3007

  • Png
    • no transparency
    • transparency
  • Jpeg

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) September 17, 2025 23:54 Inactive
@timon-schelling timon-schelling moved this to In progress in Desktop Application Sep 18, 2025
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) September 18, 2025 16:22 Inactive
@timon-schelling timon-schelling changed the base branch from master to convert-texture September 18, 2025 16:37
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) September 19, 2025 00:54 Inactive
@timon-schelling timon-schelling added the Desktop Native desktop API work with Windows/Mac/Linux and CEF label Sep 19, 2025
Base automatically changed from convert-texture to master September 25, 2025 18:54
@TrueDoctor TrueDoctor force-pushed the master branch 2 times, most recently from 4351bac to ffc7427 Compare September 26, 2025 12:30
@timon-schelling timon-schelling marked this pull request as ready for review September 26, 2025 22:10
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) September 26, 2025 22:13 Inactive
@timon-schelling timon-schelling moved this from In progress to In review in Desktop Application Sep 28, 2025
Comment thread node-graph/gsvg-renderer/src/renderer.rs Outdated
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) October 1, 2025 11:41 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) October 1, 2025 12:03 Inactive
@github-actions

This comment was marked as off-topic.

Comment on lines +64 to +65
let editor_api = editor_api.eval(None).await;
!render_params.for_export && editor_api.editor_preferences.use_vello() && matches!(render_params.render_output_type, graphene_svg_renderer::RenderOutputType::Vello)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it wouldn't make sense if we did this in the runtime too but I guess we can do that in a different pr

@github-actions

This comment was marked as off-topic.

Comment thread editor/src/messages/frontend/frontend_message.rs Outdated
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) October 1, 2025 14:33 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) October 1, 2025 14:48 Inactive
@timon-schelling timon-schelling merged commit 7e8c6cc into master Oct 1, 2025
4 checks passed
@timon-schelling timon-schelling deleted the desktop-native-export branch October 1, 2025 19:13
@github-project-automation github-project-automation Bot moved this from In review to Done in Desktop Application Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Desktop Native desktop API work with Windows/Mac/Linux and CEF

Projects

Development

Successfully merging this pull request may close these issues.

Export images with native Vello rendering

2 participants