fix: typo in fs_update_document_increment sample#2427
Merged
andrewferlitsch merged 1 commit intomasterfrom Oct 9, 2019
Merged
Conversation
googlebot
added
the
cla: yes
BenWhitehead
force-pushed
the
BenWhitehead-patch-1
branch
from
b713dd9 to
9d64583
Compare
Contributor
Author
|
Build test hangs are due to googleapis/google-cloud-python#9008 submitted fix is googleapis/google-cloud-python#9337. |
Contributor
Author
|
Waiting for next release of |
Contributor
|
@BenWhitehead Just verifying from your comment, that this PR request is not ready for review until next release of google-cloud-core? |
Contributor
Author
|
@andrewferlitsch Correct. I think a new release is scheduled to be out in the next day or two. |
Contributor
Author
|
@crwilcox the build is green after the latest release. Can you please merge this? |
Contributor
|
@BenWhitehead Does this fix the listen tests? |
Contributor
|
I just tested, this fixes the listen tests, we should re-enable them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2374