add get-disk command for VMDK/VHD extraction#2
Open
borje wants to merge 2 commits into
Open
Conversation
Adds a new `get-disk` command that extracts a virtual disk from a VBK archive as a flat raw image. Multi-extent VMDKs are reassembled automatically by the underlying vbktoolkit OpenDiskImage API. - SHA-256 verification computed inline during extraction (io.MultiWriter) rather than in a second read pass, keeping memory and I/O constant regardless of disk size - Output file is removed automatically on any error after creation, preventing partial images from being left on disk - BytesWritten is validated against the image's reported DiskSize; a mismatch is treated as a hard error - Exports vbkshell.NormalizePath so path handling is shared rather than duplicated across commands - Pins the local vbktoolkit replace directive, which fixes the root cause: DirItem.Open() previously rejected DirItemExtFib files (external files), meaning any VMDK stored as an external entry could not be read Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract virtual disks as flat raw images