Skip to content

Docker documentation (v5)#3859

Closed
asbjornu wants to merge 4 commits into
GitTools:support/5.xfrom
asbjornu:feature/docker-docs-v5
Closed

Docker documentation (v5)#3859
asbjornu wants to merge 4 commits into
GitTools:support/5.xfrom
asbjornu:feature/docker-docs-v5

Conversation

@asbjornu

Copy link
Copy Markdown
Member

Description

Add documentation for Docker usage (rebased version of #3858).

Motivation and Context

It's currently not documented how to use GitVersion through Docker.

How Has This Been Tested?

I've executed the docs build locally.

Screenshots (if appropriate):

Docker usage documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Make build.ps1 executable (chmod +x) and execute using `/usr/bin/env`
so the `PATH` is taken into consideration when finding the `pwsh`
binary.
@arturcic

arturcic commented Jan 8, 2024

Copy link
Copy Markdown
Member

@asbjornu because the v5.x branch is readonly I think the docs will get updated with the v6 release if you don't mind.

Overwise we can manually call the publish of the docs if we want to have the changes published earlier.

What do you think?

@asbjornu

asbjornu commented Jan 8, 2024

Copy link
Copy Markdown
Member Author

@arturcic, yeah. I was unsure about that. I think this is worth getting in. Is the docs publishing already possible to invoke manually, so it's not a lot of work?

@arturcic

arturcic commented Jan 8, 2024

Copy link
Copy Markdown
Member

Yes, it should be possible

@asbjornu

asbjornu commented Jan 8, 2024

Copy link
Copy Markdown
Member Author

Cool, do you approve of the changes otherwise?

@arturcic

arturcic commented Jan 8, 2024

Copy link
Copy Markdown
Member

I will check tomorrow the best option to publish the changes

@arturcic

Copy link
Copy Markdown
Member

@asbjornu I manually published from v5 https://gitversion.net/docs/usage/docker so I will close this PR

@arturcic arturcic closed this Jan 10, 2024
@asbjornu asbjornu deleted the feature/docker-docs-v5 branch January 10, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants