Skip to content

Fixed typo in image reference commit id#3284

Merged
asbjornu merged 1 commit into
GitTools:support/5.xfrom
sivarajans:patch-typo-fix
Nov 11, 2022
Merged

Fixed typo in image reference commit id#3284
asbjornu merged 1 commit into
GitTools:support/5.xfrom
sivarajans:patch-typo-fix

Conversation

@sivarajans

@sivarajans sivarajans commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

Description

There was a typo in commit id reference in document

gep13
gep13 approved these changes Nov 11, 2022
View reviewed changes

@gep13 gep13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13

gep13 commented Nov 11, 2022

Copy link
Copy Markdown
Member

@sivarajans wow! That is a great find! Thanks for catching that!

@asbjornu asbjornu changed the base branch from main to support/5.x November 11, 2022 08:38
@asbjornu

asbjornu commented Nov 11, 2022

Copy link
Copy Markdown
Member

I think this is something we should do for v5, so I tried changing the base branch from main to support/5.x, but that of course needs a proper rebase. Are you able to do that @sivarajans? If not, I'll cherry-pick 248b901 into a new PR.

@sivarajans

sivarajans commented Nov 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think this is something we should do for v5, so I tried changing the base branch from main to support/5.x, but that of course needs a proper rebase. Are you able to do that @sivarajans? If not, I'll cherry-pick 248b901 into a new PR.

Let me fix this

@sivarajans

sivarajans commented Nov 11, 2022

Copy link
Copy Markdown
Contributor Author

@asbjornu I have updated to feed this change to support/5.x branch.

@asbjornu

asbjornu commented Nov 11, 2022

Copy link
Copy Markdown
Member

@sivarajans, awesome! Thanks! 🙏🏼

@asbjornu asbjornu merged commit 552710f into GitTools:support/5.x Nov 11, 2022
@asbjornu asbjornu added this to the 5.x milestone Nov 11, 2022
@mergify

mergify Bot commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

Thank you @sivarajans for your contribution!

arturcic pushed a commit that referenced this pull request Nov 11, 2022
@web-flow
Continuous Integration Publish: 552710f
b2b9378 
Merge pull request #3284 from sivarajans/patch-typo-fix

Fixed typo in image reference commit id
@arturcic arturcic modified the milestones: 5.x, 6.x, 6.0.0-alpha.1 Dec 19, 2022
@arturcic

arturcic commented Dec 22, 2022

Copy link
Copy Markdown
Member

🎉 This issue has been resolved in version 6.0.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

This was referenced Jul 25, 2025
Open
Closed
Open
Closed
This was referenced Aug 5, 2025
Open
Closed
@dependabot dependabot Bot mentioned this pull request Aug 15, 2025
Closed
This was referenced Aug 22, 2025
Open
Open
Open
Closed
This was referenced Aug 27, 2025
Closed
Open
Merged
@dependabot dependabot Bot mentioned this pull request Oct 1, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Nov 1, 2025
Closed
This was referenced Nov 10, 2025
Open
Closed
@dependabot dependabot Bot mentioned this pull request Jan 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gep13 gep13 gep13 approved these changes

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

6.0.0-alpha.1

Development

Successfully merging this pull request may close these issues.

4 participants

@sivarajans @gep13 @asbjornu @arturcic