fix: build all packages before snapshot publish by ryanbas21 · Pull Request #669 · ForgeRock/ping-javascript-sdk

ryanbas21 · 2026-06-03T17:23:44Z

Summary

The snapshot job was calling pnpm publish -r without first building all packages, causing packages to be published without dist/ directories
Added pnpm nx run-many -t build --no-agents --skip-nx-cache before the version step, matching the pattern already used by ci:release in the publish-or-pr job
--skip-nx-cache ensures builds use the freshly-versioned package.json rather than a stale cached artifact

Test plan

Trigger the snapshot workflow on a branch and confirm packages include dist/ directories

Summary by CodeRabbit

Release Notes

Chores
- Improved reliability of snapshot publishing by adding build validation to the release workflow.

changeset-bot · 2026-06-03T17:23:59Z

⚠️ No Changeset found

Latest commit: 1b20f18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-06-03T17:23:59Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9ca95202-6288-4feb-886d-e0b04b0eed73

📥 Commits

Reviewing files that changed from the base of the PR and between d947ac2 and 1b20f18.

📒 Files selected for processing (1)

.github/workflows/publish.yml

📝 Walkthrough

Walkthrough

The PR adds an explicit build step to the snapshot publishing GitHub Actions workflow, ensuring all packages are built before versioning and publishing occurs.

Changes

Snapshot Publishing Workflow

Layer / File(s)	Summary
Explicit package build before publishing `.github/workflows/publish.yml`	A new step runs `pnpm nx run-many -t build` with flags to disable agents and skip NX cache before the snapshot versioning and publish steps execute.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

ForgeRock/ping-javascript-sdk#421: Modifies .github/workflows/publish.yml by adding steps earlier in the publish snapshot workflow (npm global update before installs).
ForgeRock/ping-javascript-sdk#497: Adds a build step to the publish workflow before publishing and changeset tagging using NX.
ForgeRock/ping-javascript-sdk#551: Modifies the NX multi-target build invocation in the publish flow, including --skip-nx-cache flag adjustment.

Suggested reviewers

ancheetah

Poem

🐰 Build before you publish, or so the error spoke,
A step we've now made explicit, to prevent the broken joke.
Three lines in the workflow, a checkpoint strong and true,
All packages built together, before the snapshot's due! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description clearly explains the problem, solution, and rationale. However, it does not follow the required template structure with JIRA Ticket and Description sections.	Restructure the description to match the template format with explicit 'JIRA Ticket' and 'Description' sections, and confirm whether a changeset was added.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: adding a build step before snapshot publishing to ensure packages include dist/ directories.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/snapshot-missing-build-step

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-06-03T17:24:39Z

View your CI Pipeline Execution ↗ for commit 1b20f18

Command	Status	Duration	Result
`nx run-many -t build --no-agents`	✅ Succeeded	<1s	View ↗
`nx affected -t build lint test typecheck e2e-ci`	✅ Succeeded	6m 49s	View ↗

☁️ Nx Cloud last updated this comment at 2026-06-03 17:31:56 UTC

pkg-pr-new · 2026-06-03T17:32:10Z

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/@forgerock/davinci-client@669

@forgerock/device-client

pnpm add https://pkg.pr.new/@forgerock/device-client@669

@forgerock/journey-client

pnpm add https://pkg.pr.new/@forgerock/journey-client@669

@forgerock/oidc-client

pnpm add https://pkg.pr.new/@forgerock/oidc-client@669

@forgerock/protect

pnpm add https://pkg.pr.new/@forgerock/protect@669

@forgerock/sdk-types

pnpm add https://pkg.pr.new/@forgerock/sdk-types@669

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/@forgerock/sdk-utilities@669

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/@forgerock/iframe-manager@669

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/@forgerock/sdk-logger@669

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/@forgerock/sdk-oidc@669

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/@forgerock/sdk-request-middleware@669

@forgerock/storage

pnpm add https://pkg.pr.new/@forgerock/storage@669

commit: 1b20f18

github-actions · 2026-06-03T17:32:40Z

Deployed e9974ee to https://ForgeRock.github.io/ping-javascript-sdk/pr-669/e9974ee185b181bfa297e36411f8e6703ebcd22d branch gh-pages in ForgeRock/ping-javascript-sdk

codecov-commenter · 2026-06-03T17:32:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.89%. Comparing base (eafe277) to head (1b20f18).
⚠️ Report is 24 commits behind head on main.

❌ Your project status has failed because the head coverage (19.89%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   18.07%   19.89%   +1.82%     
==========================================
  Files         155      158       +3     
  Lines       24398    24799     +401     
  Branches     1203     1335     +132     
==========================================
+ Hits         4410     4934     +524     
+ Misses      19988    19865     -123

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-06-03T17:32:51Z

📦 Bundle Size Analysis

🆕 New Packages

🆕 @forgerock/protect - 144.6 KB (new)
🆕 @forgerock/sdk-types - 7.9 KB (new)
🆕 @forgerock/device-client - 10.0 KB (new)
🆕 @forgerock/device-client - 0.0 KB (new)
🆕 @forgerock/iframe-manager - 2.4 KB (new)
🆕 @forgerock/storage - 1.5 KB (new)
🆕 @forgerock/sdk-request-middleware - 4.6 KB (new)
🆕 @forgerock/sdk-logger - 1.6 KB (new)
🆕 @forgerock/sdk-oidc - 5.7 KB (new)
🆕 @forgerock/journey-client - 91.9 KB (new)
🆕 @forgerock/journey-client - 0.0 KB (new)
🆕 @forgerock/sdk-utilities - 11.2 KB (new)
🆕 @forgerock/davinci-client - 54.0 KB (new)
🆕 @forgerock/oidc-client - 30.5 KB (new)

14 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated

Current Size: Total gzipped size of all files in the package's dist directory
Baseline: Comparison against the latest build from the main branch
Files included: All build outputs except source maps and TypeScript build cache
Exclusions: .map, .tsbuildinfo, and .d.ts.map files

_{🔄 Updated automatically on each push to this PR}

chore: fix-snapshot

1b20f18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: build all packages before snapshot publish#669

fix: build all packages before snapshot publish#669
ryanbas21 wants to merge 1 commit into
mainfrom
fix/snapshot-missing-build-step

ryanbas21 commented Jun 3, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Jun 3, 2026

Uh oh!

coderabbitai Bot commented Jun 3, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

nx-cloud Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

codecov-commenter commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

ryanbas21 commented Jun 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Release Notes

Uh oh!

changeset-bot Bot commented Jun 3, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

nx-cloud Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

codecov-commenter commented Jun 3, 2026

Codecov Report

Uh oh!

github-actions Bot commented Jun 3, 2026

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🆕 New Packages

Legend

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

ryanbas21 commented Jun 3, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 3, 2026 •

edited

Loading

nx-cloud Bot commented Jun 3, 2026 •

edited

Loading