chore(skill): remove skill update + drop sync-noise output#387
Merged
Conversation
…d/remove `skill update` was metadata-only — it rewrote sync-state hashes but didn't copy any new files. `allagents update` already does the real refresh (fetches from remote + copies into the client dirs), so the per-skill command was a redundant footgun. Drops it entirely: - src/cli/commands/plugin-skills.ts: remove `updateCmd`, the `SkillUpdateRow` type, the unused `loadSyncState` import, and the `update:` entry in `skillsCmd.cmds`. The helpers `resolveSkillFolder`, `computeSkillFolderHash`, `upsertSyncStateSource`, and `upsertSyncStateSkill` stay — they're still used by `recordContentProvenance` on the `skill add` path. - src/cli/metadata/plugin-skills.ts: delete `skillsUpdateMeta`. - src/cli/agent-help.ts: drop the import and the entry in `allCommands`. - tests/unit/cli/agent-help.test.ts: drop the import, the entry, the count goes 18 → 17, and 'skill update' is removed from the expected-names list. Also drops the redundant "Syncing workspace... / Sync complete." pair from the `skill add`/`skill remove` handlers (six call sites). The "✓ Enabled/Disabled skill: ..." line already confirms the action and the sync output (file counts per client) follows when there's something to report; the two extra status lines are pure noise between them.
Deploying allagents with
|
| Latest commit: |
744ee82
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10e63e97.allagents.pages.dev |
| Branch Preview URL: | https://chore-remove-skill-update-cl.allagents.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two cleanups against the recently-merged
skill *group.1. Remove
allagents skill updateThe command was metadata-only — it rewrote
sources[...].skills[*].contentHash/updatedAtand stampedpinnedRef, but it never copied any files into the client directories.allagents updatealready does the real refresh (fetch from remote + copy viasyncWorkspace), so the per-skill command was a redundant footgun: a user running it after upstream changed would see "✓ updated" while their installed skills stayed at the old version.Removed:
updateCmddefinition +SkillUpdateRowtype insrc/cli/commands/plugin-skills.tsskillsUpdateMetainsrc/cli/metadata/plugin-skills.tsupdate:entry inskillsCmd.cmdssrc/cli/agent-help.ts(allCommandsarray + import)tests/unit/cli/agent-help.test.ts(count 18 → 17,'skill update'removed from the expected-names list)loadSyncStateimportThe supporting helpers (
computeSkillFolderHash,upsertSyncStateSource,upsertSyncStateSkill,resolveSkillFolder) stay — they're still used byrecordContentProvenanceon theskill addpath so drift detection keeps working.2. Drop "Syncing workspace… / Sync complete." noise in
skill add/skill removeSix call sites printed
The first and last lines were redundant —
✓ Enabled/Disabled skill: …already confirms the action, and the sync output (per-client artifact counts) follows when there's something to report. Removed all six.Test plan
bun run buildbun run typecheckbun test— 1209 pass / 0 failSyncing workspaceorSync completestrings insrc/cli/commands/plugin-skills.tsupdateCmd,SkillUpdateRow,skillsUpdateMeta, orskill updateanywhere insrc/ortests/