Bring Elements up to date with Bitcoin Core 0.21#935
Merged
stevenroose merged 9112 commits intoApr 6, 2021
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires a bunch of followup work which I will open other issues for. See also #743 which was our checklist for 0.19.
Then in followup PRs:
Fix the fuzz tests; I did not test these at any point throughout the rebase Post-0.21: fix fuzz tests #936merge-prsscript to run the fuzzer, linter etc., as well as do a full cleanmake checkWIP: Addmerge-prs.shscript to contrib/ #923signblockRPC which involves both wallet and node logic. Core's solution to this for Signet may be to introduce a separate signblock tool which we may want to also do; see #bitcoin-core-dev IRC logs for the meeting on 2020-12-03. Post-0.21: Separate wallet and node #939loadblockstest, assess the "extended tests" which are broken on master Post-0.21: functional test failures #940g_con_elementsmodeAssess current value ofg_con_elementsmodeand consider removal #929pak=format is undocumented and there is no functional test for it #926), movecomputefastmerklerootinto Python rather than using the RPC; Implement fast merkleroot computations in Python #941bumpfeeRPC to support CT. There is an existing issue for this Fix bumpfee #527-enforce_pakis off on a network that uses PAK proofs #925 which was discovered through the rebase.bilingual_strfromstd::stringfor many Core RPCs; we should follow suit for our own RPCs Post-0.21: usebilingual_strrather thanstd::stringin RPCs and elsewhere #942avoid_reuseparam tosendtoaddressand a couple other RPCs moves some Elements fields out of the way. For backward compatibility we should putavoid_reuseafter these Elements fields. (I think this is the only time I did this; after talking to Glenn I tried to make future RPC extensions backward compatible)feefield of the RPC output)Then a couple large followups. Tracking issues: