Added ShopDeleted and ShopCreated SSEs and Id property to shops.#44
Open
Iliuyux wants to merge 3 commits into
Open
Added ShopDeleted and ShopCreated SSEs and Id property to shops.#44Iliuyux wants to merge 3 commits into
Iliuyux wants to merge 3 commits into
Conversation
Veyronity
requested changes
May 22, 2026
|
|
||
| public static JsonObject getShopObject(Shop shop) { | ||
| JsonObject jsonObject = new JsonObject(); | ||
| jsonObject.addProperty("Id", shop.getShopId()); |
Contributor
There was a problem hiding this comment.
Please make this lowercase
| It is important to note that the information here is not public, and players can only access their own shops' information, using their API key. | ||
|
|
||
| Each shop object has the following properties: | ||
| - `Id` - The unique identifier of the shop |
| [ | ||
| { | ||
| "1": { | ||
| "Id": 120, |
Author
|
Done 👍 |
Veyronity
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ShopDeleted and ShopCreated events, and every shop object now includes the unique shop Id property.