Updates to Technote section 2.9 Stomatal Resistance and Photosynthesis

[slevis-lmwg]

Description of changes

For link to the pdf with proposed changes see the corresponding issue:
#3855 (comment)

Specific notes

Contributors other than yourself, if any:
@gbonan

CTSM issues resolved or otherwise addressed, if any:
Resolves #3855

Requirements before merge:

• I have followed the CTSM contribution guidelines.

[slevis-lmwg]

@gbonan just a heads up that I will request your review of these updates when I'm done.
So far I have addressed 2a and 2b from your pdf.

[slevis-lmwg]

@gbonan I have now addressed issue (3) from your pdf.

Regarding issue (4), I found the equation in this form:
jmax25top = ((2.59_r8 - 0.035_r8*min(max((t10(p)-tfrz),11._r8),35._r8)) * vcmax25top) * params_inst%jmax25top_sf
Does the jmax25top_sf (scaling factor) parameter at the end correspond to what's discussed in the Canopy Scaling subsection of Section 2.9? That I'm not sure about. Do you know?

[slevis-lmwg]

Answered my question about the missing jmax25top_sf in the documentation:
jmax25top_sf = 1 in the clm paramfile, so it's ok to not mention in the documentation.

I have now addressed issue (6) and I will go along with your assessment in issue (7) rather than pursuing further.

[slevis-lmwg]

I left the most difficult (or time consuming) of Gordon's issues for last, and I am considering opening a separate PR for it for clearer tracking. This is what's left:

Parameters are given in Table 2.9.1, Table 2.9.2, or are in the text. These need to be updated. There are a lot!

[slevis-lmwg]

Notes to self:

• Paused at Rd25 before eq. 2.9.9 (check params in SP mode; BGC mode already addressed)
• Saved latest paramfile in /glade/derecho/scratch/slevis/ctsm60_params.c260518.asc`

[wwieder]

Are you ready for a review on this one, @slevis-lmwg, or still working?

[slevis-lmwg]

Still working through the parameters.

[slevis-lmwg]

Ready for review. Reaching out to @gbonan but others are welcome to look, as well. Gordon, I will also reach out to you via email or chat.

[samsrabin]

Stamp of approval for Gordon.