feat: add RHEL flavors to server setup script#4037
Open
snitramodranoel wants to merge 1 commit intoDokploy:canaryfrom
Open
feat: add RHEL flavors to server setup script#4037snitramodranoel wants to merge 1 commit intoDokploy:canaryfrom
snitramodranoel wants to merge 1 commit intoDokploy:canaryfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Adds other RHEL flavors to the "almalinux" case block in the server setup script, allowing setting up other distros. Tested with Rocky Linux, CentOS, and RHEL.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #3887
Screenshots (if applicable)
Greptile Summary
This PR extends the Docker installation logic in
server-setup.tsto cover additional RHEL-family Linux distributions (rocky,centos,rhel,ol) by adding them to the existingalmalinuxcase, so they all use Docker's official CentOS CE repository instead of the genericget.docker.comscript. This aligns with Docker's documented installation approach for these distros.Key points:
installUtilities()already groupscentos | fedora | rhel | ol | rocky | almalinuxtogether.systemctl start dockerandsystemctl enable docker, maintaining the same post-install behaviour thatrockyandcentospreviously received in the*)fallback.*)fallback now contains deadif [ "$OS_TYPE" = "rocky" ]andif [ "$OS_TYPE" = "centos" ]blocks (lines 599–607) that can never be reached — these should be removed.Confidence Score: 4/5
*)fallback branch.if [ "$OS_TYPE" = "rocky" ]andif [ "$OS_TYPE" = "centos" ]blocks at lines 599–607 ofpackages/server/src/setup/server-setup.ts.Comments Outside Diff (1)
packages/server/src/setup/server-setup.ts, line 599-607 (link)rockyandcentosblocks now unreachableSince
"rocky"and"centos"are now matched by the new case branch at line 502, the twoifblocks below (lines 599–607) inside the*)fallback branch can never be reached. These should be removed to avoid confusion.Specifically, the entire block from line 599 to 607:
should be deleted, as
rockyandcentosnow go through the new explicit branch which already callssystemctl start dockerandsystemctl enable docker.Last reviewed commit: "feat: add RHEL flavo..."
(2/5) Greptile learns from your feedback when you react with thumbs up/down!