Update railpack version to 0.19.0#4022
Open
jdjimenez2312 wants to merge 2 commits intoDokploy:canaryfrom
Open
Conversation
…hema, and server setup
|
Related Documentation 1 document(s) may need updating based on files changed in this PR: Dokploy's Space CONTRIBUTING
|
Comment on lines
701
to
706
| if command_exists railpack; then | ||
| echo "Railpack already installed ✅" | ||
| else | ||
| export RAILPACK_VERSION=0.15.4 | ||
| export RAILPACK_VERSION=0.19.0 | ||
| bash -c "$(curl -fsSL https://railpack.com/install.sh)" | ||
| echo "Railpack version $RAILPACK_VERSION installed ✅" |
Contributor
There was a problem hiding this comment.
Existing installations won't be upgraded
The installRailpack function skips installation entirely if railpack is already present, without checking which version is installed. This means that existing server instances already running railpack 0.15.4 (or any older version) will not be upgraded to 0.19.0 when the setup script is re-run.
Consider adding a version check so the installer upgrades when the detected version is older than the expected one:
if command_exists railpack; then
INSTALLED=$(railpack --version 2>/dev/null || echo "0.0.0")
if [ "$INSTALLED" = "0.19.0" ]; then
echo "Railpack already installed ✅"
else
echo "Upgrading Railpack from $INSTALLED to 0.19.0..."
export RAILPACK_VERSION=0.19.0
bash -c "$(curl -fsSL https://railpack.com/install.sh)"
echo "Railpack version $RAILPACK_VERSION installed ✅"
fi
else
export RAILPACK_VERSION=0.19.0
bash -c "$(curl -fsSL https://railpack.com/install.sh)"
echo "Railpack version $RAILPACK_VERSION installed ✅"
fi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Please describe in a short paragraph what this PR is about.
Update railpack version to 0.19.0
Before submitting this PR, please make sure that:
canarybranch.Greptile Summary
This PR bumps the Railpack build tool from version
0.15.4to0.19.0, correctly updating the Dockerfile, the database schema default, the drizzle migration, the server setup script, and the UI version list. However, five hardcoded"0.15.4"string literals remain inshow.tsxthat were not updated alongside the rest of the changes, causing the UI to still default to and badge the old version.Key issues found:
railpackVersionis still"0.15.4"(line 100), so newly created applications via the UI form will start with the old version pre-selected.data.railpackVersion || "0.15.4", line 236) will persist the old version to the database if the field is ever empty.Selectfallback value (line 490), and the"Latest"badge condition (line 504) all still reference"0.15.4"— meaning0.15.4will appear visually labelled as "Latest" in the dropdown even after this update.server-setup.ts, the install function skips execution when railpack is already present without checking the installed version, so existing servers will not be upgraded.Confidence Score: 2/5
show.tsxhas five stale"0.15.4"references. This means users interacting with the build settings UI will see the wrong default and a misleading "Latest" badge on the old version, and in some code paths the old version could be persisted to the database."0.15.4"to"0.19.0"(or ideallyRAILPACK_VERSIONS[0]to be future-proof).Comments Outside Diff (5)
apps/dokploy/components/dashboard/application/build/show.tsx, line 100 (link)The Zod schema default for
railpackVersionstill references"0.15.4"instead of the new version"0.19.0". This means that when a user creates a new application with Railpack build type through the UI form, the form will initially populate with the outdated version.apps/dokploy/components/dashboard/application/build/show.tsx, line 236 (link)The fallback used when saving the build type still references
"0.15.4". IfrailpackVersionis falsy for any reason, the API call will store the outdated version in the database, even though the database default and all other places have been updated to"0.19.0".apps/dokploy/components/dashboard/application/build/show.tsx, line 474-490 (link)Three separate
"0.15.4"references remain in the version selector UI:"0.15.4"instead of"0.19.0".Selectcomponent'svalueprop falls back to"0.15.4"whenfield.valueis nullish, so the dropdown will appear to select the old version."Latest"badge is hard-coded to the string"0.15.4", so version0.15.4will still be visually labelled as the latest version instead of0.19.0.Consider using
RAILPACK_VERSIONS[0]for the badge check and version fallback, so future version bumps only need to be made in theRAILPACK_VERSIONSarray:apps/dokploy/components/dashboard/application/build/show.tsx, line 504 (link)The badge condition is hardcoded to
"0.15.4", so users will see0.15.4labelled as "Latest" in the version dropdown even though0.19.0is now the current default. UsingRAILPACK_VERSIONS[0]keeps this dynamic and avoids needing to update it on every version bump.apps/dokploy/components/dashboard/application/build/show.tsx, line 464 (link)The placeholder text in the manual version input still shows
0.15.4as an example. While this is just a UI hint, it is misleading for users who are trying to enter the newest version.Last reviewed commit: "Migration"
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!