Remove argument from use_hook closure#496
Merged
Merged
Conversation
Also; update docs for said function
jkelleyrtp
approved these changes
Jul 11, 2022
sahina
pushed a commit
to sahina/dioxus
that referenced
this pull request
Jul 19, 2022
Also; update docs for said function
ealmloff
added a commit
that referenced
this pull request
Sep 5, 2022
* minor formatting * Internationalization: move guide to en folder and preserve its history. (#494) * chore: move guide to en folder * docs: add english as language * merged conf resolved * chore: remove outdated docs * chore: use taffy dimension directly * Add PT-BR translations (#456) * Translate final.md, hello_world.md, README.md, ROADMAP.md and SUMMARY.md * Translatation complete * Internationalization: move guide to en folder and preserve its history. (#494) * Clean files and build mdBook with localization feature * Rebase, remove leftovers and check book builds for every language: ✅ Co-authored-by: Jon Kelley <jkelleyrtp@gmail.com> * Remove argument from `use_hook` closure (#496) Also; update docs for said function * chore: prevent reference from being uploaded Co-authored-by: Altug Sahin <altugsahin@gmail.com> Co-authored-by: Jon Kelley <jkelleyrtp@gmail.com> Co-authored-by: Breno Rocha <66398400+amindWalker@users.noreply.github.com> Co-authored-by: Reinis Mazeiks <rMazeiks@users.noreply.github.com> Co-authored-by: = <evanalmloff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
Alternative: we could make
use_hooktake a traitimpl UseHookFn, and implement it for both()->Tand(usize)->T, and deprecate the latter, but breaking it seems better: