Renderers are now packages, not features.#387
Conversation
3963146 to
b28a3f1
Compare
08aa20c to
4c84e37
Compare
2c8a683 to
4136790
Compare
rMazeiks
left a comment
There was a problem hiding this comment.
I don't understand where a bunch of changes are comming from; this is supposed to be just a re-structuring right? Might wanna check what Git has done here in the diff. Anyway, the other stuff looks good!
| @@ -0,0 +1,185 @@ | |||
| //! Example: Antipatterns | |||
There was a problem hiding this comment.
i deleted some of these examples when i re-wrote the guide
the guide now contains the parts of this info i found important, in a more concise form
any reason for adding them back or just git merge madness?
There was a problem hiding this comment.
merge madness :) I need to figure out which ones slipped through
| } | ||
| }); | ||
|
|
||
| cx.provide_context(svc) |
There was a problem hiding this comment.
deleting this seems sus and unrelated, is it intentional?
ealmloff
left a comment
There was a problem hiding this comment.
This seems much more organized. 🙂
A few things I noticed that don't fit specific lines:
- There are some dioxus::{plaform} imports left in the docs/guide/examples
- The tui_benchmark should probably be moved from the dioxus to the tui crate
- I think we can remove rsx-prelude now
e90fb20 to
bacda49
Compare
bacda49 to
edd148d
Compare
* feat: use synchronous router design * feat: function to get router out of dom * chore: restructure workspace to use renderers as packages, not features
This PR changes how we do packages since things have started to become unwieldy when adding functionality to crates like the router, fermi, and 3rd party renderers.
Now, all renderers are their own package and need to be added to Cargo.toml as such:
Instead of
dioxus::web::launchyou'll dodioxus_web::launch.For releases, we'll using the minor version to keep things in lock step, but freely bump minor versions as new updates are pushed. It should've been this way since the beginning but I was experimenting. This also gets rid of the rsx-prelude which was a patch until we had a better solution.
The benefits:
The stuff that remains under "dioxus" includes: