Skip to content

Cast window ID to int value in find window binary #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirovboris merged 1 commit into from
May 23, 2023
Merged

Cast window ID to int value in find window binary #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified bin/mac/TestCafe Browser Tools.app/Contents/MacOS/testcafe-browser-tools
View file
Open in desktop
Binary file not shown.
Binary file modified bin/mac/main
View file
Open in desktop
Binary file not shown.
17 changes: 7 additions & 10 deletions src/natives/utils/mac/utils.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,18 @@ id getApplicationForProcess (NSString *processId) {
}

id getWindowOfApplication (id app, NSString *windowId) {
id windows = [app windows];
id windowsProperties = [windows arrayByApplyingSelector:@selector(properties)];
id windows = [app windows];

NSUInteger index = [windowsProperties indexOfObjectPassingTest:^(NSDictionary *properties, NSUInteger index, BOOL *stop){
return [[properties[@"id"] stringValue] isEqualToString: windowId];
}];
for (id window in windows) {
if ([[window properties][@"id"] intValue] == [windowId intValue])
return window;
}

if (index == NSNotFound)
return nil;

return windows[index];
return nil;
}

id getWindowOfProcess (NSString *processId, NSString *windowId) {
id app = getApplicationForProcess(processId);

return getWindowOfApplication(app, windowId);
}
}