Add OAuth support for {aws, gcp} integrations#443
Merged
platinummonkey merged 2 commits intoDataDog:mainfrom May 1, 2026
Merged
Conversation
Adds the two scopes to default_scopes and read_only_scopes (matching the existing azure_configuration_read pattern) so `pup cloud aws list` and `pup cloud gcp list` work after Datadog enables OAuth on the underlying API routes. Closes DataDog#437.
srosenthal-dd
changed the title
platinummonkey
previously approved these changes
Apr 29, 2026
Member
Author
|
Note: AWS fix is rolled out server-side. GCP service-side OAuth fix is rolling out right now, so should be done by the end of the day, if nothing goes wrong. EDIT: the server side updates are done. This is ready to merge. |
…loud-aws-gcp-oauth-scopes # Conflicts: # src/auth/types.rs
platinummonkey
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: Ready to merge!
Addresses #437.
Summary
Adds
aws_configuration_readandgcp_configuration_readtodefault_scopesandread_only_scopesinsrc/auth/types.rs, following the existingazure_configuration_readpattern. Test count assertion bumped 81 → 83 with positive assertions for the two new scopes.Without this,
pup cloud {aws,gcp} list401s even after Datadog enables OAuth on the underlying routes, because pup's OAuth client doesn't request the right scopes at login.Also required server-side configuration updates, which were applied separately.
Test plan
cargo build,cargo test --bin pup auth::types,cargo clippy --all-targets -- -D warnings,cargo fmt --checkall cleanpup auth loginagainst staging, thenpup cloud aws listreturns real datapup auth loginagainst staging, thenpup cloud gcp listreturns real dataJira: https://datadoghq.atlassian.net/browse/DAL-508