fix(ipc): Fallback to ftruncate if fallocate gets EPERM#1938
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom May 4, 2026
Merged
fix(ipc): Fallback to ftruncate if fallocate gets EPERM#1938gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
Conversation
bwoebi
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00b9d8d24f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
bwoebi
force-pushed
the
bob/fallocate-fallback
branch
from
00b9d8d to
a70521b
Compare
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
bwoebi
force-pushed
the
bob/fallocate-fallback
branch
from
a70521b to
65e0028
Compare
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: d2bd8fd | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1938 +/- ##
==========================================
- Coverage 71.72% 71.70% -0.02%
==========================================
Files 434 434
Lines 70379 70384 +5
==========================================
- Hits 50480 50471 -9
- Misses 19899 19913 +14
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
bwoebi
force-pushed
the
bob/fallocate-fallback
branch
4 times, most recently
from
0e72b16 to
d34a83c
Compare
morrisonlevi
approved these changes
Apr 30, 2026
Contributor
morrisonlevi
left a comment
morrisonlevi
left a comment
There was a problem hiding this comment.
BTW, we think this happens because of seccomp. Patch looks good, have some very minor suggestions.
Comment on lines
96
to
97
| // Use fallocate on Linux to eagerly commit the new pages: ENOSPC at resize time is | ||
| // recoverable; a later SIGBUS mid-execution is not. |
| new_size, | ||
| )?; | ||
| ) { | ||
| Err(nix::Error::EPERM | nix::Error::ENOSYS) => nix::unistd::ftruncate(fd, new_size)?, |
Contributor
There was a problem hiding this comment.
Maybe EOPNOTSUPP? If this uses a file-based fallback then it might conceivably return that?
I have no idea how fallocate is ever returning EPERM here, but apparently it is for some users. So, ... falling back it is.
bwoebi
force-pushed
the
bob/fallocate-fallback
branch
from
d34a83c to
d2bd8fd
Compare
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no idea how fallocate is ever returning EPERM here, but apparently it is for some users. So, ... falling back it is.