Update rand crate from 0.9 to 0.10#1865
Merged
GeorgeHahn merged 1 commit intomainfrom Apr 30, 2026
Merged
Conversation
GeorgeHahn
force-pushed
the
hahn/rand-0-10
branch
from
bd71806 to
1c3521f
Compare
blt
approved these changes
Apr 29, 2026
- Remove `small_rng` feature flag (SmallRng is always available in 0.10) - Add `RngExt` import where needed (extension methods like random(), random_range(), random_bool() moved from Rng to RngExt) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
GeorgeHahn
force-pushed
the
hahn/rand-0-10
branch
from
1c3521f to
427cdc9
Compare
2 tasks
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
to DataDog/saluki
that referenced
this pull request
May 7, 2026
…nd 0.9 → 0.10 (#1609) ## Human Summary Bumps our version of `lading` up to bring in the upgrade to `rand` from DataDog/lading#1865 Subsequent PRs will bump `lading` further to bring in some updates I'm working on (see DataDog/lading#1871), just wanted to get this yak out of the way independently ## Summary - Updates `lading-payload` git rev to `01ef8d70`, picking up the rand 0.9 → 0.10 upgrade in lading (#1865) and other upstream improvements - Updates millstone's pinned `rand = "0.9"` to the workspace `rand = "0.10"` to match lading-payload's expectation - Fixes two `corpus.rs` call sites that broke with the new lading API: `DogStatsD::new` now takes `&Config` instead of `Config`, and the internal generator functions are de-genericized from `R: Rng` to concrete `StdRng` The rand 0.9 → 0.10 upgrade in rand_core changes how `Rng` is implemented: `rand_core 0.10` only blanket-implements `Rng` for types satisfying `TryRng<Error=Infallible>` via `DerefMut`, which concrete RNGs satisfy through direct impls in the rand crate. Mixing a rand 0.9 `StdRng` with a rand 0.10 trait boundary produced opaque `DerefMut` errors. The fix is to use the same rand version throughout. ## Test plan - [ ] `cargo check --workspace` passes - [ ] `cargo clippy -p millstone` passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: travis.thieman <travis.thieman@datadoghq.com>
dd-octo-sts Bot
pushed a commit
to DataDog/saluki
that referenced
this pull request
May 7, 2026
…nd 0.9 → 0.10 (#1609) ## Human Summary Bumps our version of `lading` up to bring in the upgrade to `rand` from DataDog/lading#1865 Subsequent PRs will bump `lading` further to bring in some updates I'm working on (see DataDog/lading#1871), just wanted to get this yak out of the way independently ## Summary - Updates `lading-payload` git rev to `01ef8d70`, picking up the rand 0.9 → 0.10 upgrade in lading (#1865) and other upstream improvements - Updates millstone's pinned `rand = "0.9"` to the workspace `rand = "0.10"` to match lading-payload's expectation - Fixes two `corpus.rs` call sites that broke with the new lading API: `DogStatsD::new` now takes `&Config` instead of `Config`, and the internal generator functions are de-genericized from `R: Rng` to concrete `StdRng` The rand 0.9 → 0.10 upgrade in rand_core changes how `Rng` is implemented: `rand_core 0.10` only blanket-implements `Rng` for types satisfying `TryRng<Error=Infallible>` via `DerefMut`, which concrete RNGs satisfy through direct impls in the rand crate. Mixing a rand 0.9 `StdRng` with a rand 0.10 trait boundary produced opaque `DerefMut` errors. The fix is to use the same rand version throughout. ## Test plan - [ ] `cargo check --workspace` passes - [ ] `cargo clippy -p millstone` passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: travis.thieman <travis.thieman@datadoghq.com> f91e8aa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
randfrom 0.9 to 0.10.1small_rngfeature flag (SmallRng is always available in 0.10)RngExtimport where needed (extension methods likerandom(),random_range(),random_bool()moved fromRngtoRngExt)