Revert "Revert "ci: install upstream ddtrace wheel during PR-triggered unit tests""#815
Merged
rithikanarayan merged 22 commits intomainfrom May 7, 2026
Merged
Conversation
…d unit t…" This reverts commit 42b2e54.
purple4reina
reviewed
May 5, 2026
purple4reina
reviewed
May 5, 2026
purple4reina
force-pushed
the
revert-814-revert-813-rey.abolofia/fix-ddtrace-pr
branch
from
2843da0 to
42d7c58
Compare
brettlangdon
approved these changes
May 7, 2026
Member
brettlangdon
left a comment
brettlangdon
left a comment
There was a problem hiding this comment.
one thing of notes, when using ddtrace_serverless we'll get ddtrace.__version__ reported as 0.0.0. Impact should be fairly low? unless we assert against the reported tracer version in trace payloads/telemetry/etc
purple4reina
approved these changes
May 7, 2026
rithikanarayan
deleted the
revert-814-revert-813-rey.abolofia/fix-ddtrace-pr
branch
brettlangdon
reviewed
May 7, 2026
Comment on lines
+44
to
+49
| local wheel_file | ||
| wheel_file=$(curl -sSfL "${index_url}" | grep -o "${search_pattern}" | head -n 1 || true) | ||
| if [ -z "$wheel_file" ]; then | ||
| return 1 | ||
| fi | ||
| curl -sSfL "${S3_BASE}/${wheel_file}" -o "${wheel_file}" |
Member
There was a problem hiding this comment.
Suggested change
| local wheel_file | |
| wheel_file=$(curl -sSfL "${index_url}" | grep -o "${search_pattern}" | head -n 1 || true) | |
| if [ -z "$wheel_file" ]; then | |
| return 1 | |
| fi | |
| curl -sSfL "${S3_BASE}/${wheel_file}" -o "${wheel_file}" | |
| python3 pip download --no-index --no-deps --find-links "${index_url} "${basename}" | |
| local wheel_file | |
| wheel_file=$(ls *.whl | head -n 1 || true) |
brettlangdon
reviewed
May 7, 2026
Comment on lines
+72
to
+77
| PY_TAG="cp$(echo "$PYTHON_VERSION" | tr -d '.')" | ||
| if [ "$ARCH" = "amd64" ]; then | ||
| PLATFORM="manylinux2014_x86_64" | ||
| else | ||
| PLATFORM="manylinux2014_aarch64" | ||
| fi |
Member
There was a problem hiding this comment.
Suggested change
| PY_TAG="cp$(echo "$PYTHON_VERSION" | tr -d '.')" | |
| if [ "$ARCH" = "amd64" ]; then | |
| PLATFORM="manylinux2014_x86_64" | |
| else | |
| PLATFORM="manylinux2014_aarch64" | |
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #814
Successful gitlab pipeline from dd-trace-py: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/pipelines/112067085