Skip to content

Enable triton comfy kitchen via cli-arg#12730

Open
silveroxides wants to merge 11 commits intoComfy-Org:masterfrom
silveroxides:enable-triton-comfy-kitchen
Open

Enable triton comfy kitchen via cli-arg#12730
silveroxides wants to merge 11 commits intoComfy-Org:masterfrom
silveroxides:enable-triton-comfy-kitchen

Conversation

@silveroxides
Copy link
Copy Markdown
Contributor

Adds optional launch flag for user to enable triton backend with comfy-kitchen if using custom comfy-kitchen forks such as silveroxides/comfy-kitchen

@silveroxides silveroxides marked this pull request as ready for review March 7, 2026 04:47
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5f07a313-d5bf-45c1-bd21-5bc95c727f5c

📥 Commits

Reviewing files that changed from the base of the PR and between c6052a1 and cb1c7b4.

📒 Files selected for processing (2)
  • comfy/cli_args.py
  • comfy/quant_ops.py
🚧 Files skipped from review as they are similar to previous changes (2)
  • comfy/cli_args.py
  • comfy/quant_ops.py

📝 Walkthrough

Walkthrough

Adds a new CLI flag --enable-triton-backend in comfy/cli_args.py. comfy/quant_ops.py now checks args.enable_triton_backend before attempting to enable the Triton backend: if set, the code tries to import Triton and logs success with its version or catches ImportError and disables Triton; if not set, Triton remains disabled. Existing CUDA backend discovery and checks are unchanged.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding a CLI argument to enable the Triton backend for comfy-kitchen.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of the new CLI flag and its use case with custom comfy-kitchen forks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

Flake8 can be used to improve the quality of Python code reviews.

Flake8 is a Python linter that wraps PyFlakes, pycodestyle and Ned Batchelder's McCabe script.

To configure Flake8, add a '.flake8' or 'setup.cfg' file to your project root.

See Flake8 Documentation for more details.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@comfy/cli_args.py`:
- Line 93: The help text for the CLI flag defined by
parser.add_argument("--enable-triton-backend", ...) has a grammatical error and
missing punctuation; update the help string to a single clear sentence such as
"Enable use of the Triton backend in comfy-kitchen; it is disabled at launch by
default." so the flag name --enable-triton-backend and the parser.add_argument
call carry the corrected, punctuated message.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e6b21802-e069-49e7-9fc5-626edbef4591

📥 Commits

Reviewing files that changed from the base of the PR and between afc00f0 and 433e9a2.

📒 Files selected for processing (2)
  • comfy/cli_args.py
  • comfy/quant_ops.py

@FurkanGozukara
Copy link
Copy Markdown

Dear @comfyanonymous can we give some more importance to this

thank you

#12830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants