Enable triton comfy kitchen via cli-arg#12730
Enable triton comfy kitchen via cli-arg#12730silveroxides wants to merge 11 commits intoComfy-Org:masterfrom
Conversation
…h arg is used to check if it actually works.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds a new CLI flag 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip Flake8 can be used to improve the quality of Python code reviews.Flake8 is a Python linter that wraps PyFlakes, pycodestyle and Ned Batchelder's McCabe script. To configure Flake8, add a '.flake8' or 'setup.cfg' file to your project root. See Flake8 Documentation for more details. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@comfy/cli_args.py`:
- Line 93: The help text for the CLI flag defined by
parser.add_argument("--enable-triton-backend", ...) has a grammatical error and
missing punctuation; update the help string to a single clear sentence such as
"Enable use of the Triton backend in comfy-kitchen; it is disabled at launch by
default." so the flag name --enable-triton-backend and the parser.add_argument
call carry the corrected, punctuated message.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e6b21802-e069-49e7-9fc5-626edbef4591
📒 Files selected for processing (2)
comfy/cli_args.pycomfy/quant_ops.py
|
Dear @comfyanonymous can we give some more importance to this thank you |
Adds optional launch flag for user to enable triton backend with comfy-kitchen if using custom comfy-kitchen forks such as silveroxides/comfy-kitchen