Skip to content

fix: fix segfault caused by multiple activate_stack_trampoline#109

Open
GuillaumeLagrange wants to merge 2 commits intomasterfrom
cod-2202-intermittent-crashes-on-codspeed-macro
Open

fix: fix segfault caused by multiple activate_stack_trampoline#109
GuillaumeLagrange wants to merge 2 commits intomasterfrom
cod-2202-intermittent-crashes-on-codspeed-macro

Conversation

@GuillaumeLagrange
Copy link
Copy Markdown
Contributor

@GuillaumeLagrange GuillaumeLagrange commented Mar 27, 2026

Fixes #106

Upstream CPython issue: python/cpython#146522

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 27, 2026

Merging this PR will degrade performance by 20.88%

⚡ 20 improved benchmarks
❌ 25 regressed benchmarks
✅ 232 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_recursive_fibo_20 5.2 ms 5.5 ms -5.97%
WallTime test_open_close_fd[100] 880.6 µs 901.1 µs -2.27%
WallTime test_sum_of_squares[sum_of_squares_sum_labmda_power] 310.1 µs 323.6 µs -4.16%
WallTime test_color[graph0-3] 27.9 µs 30 µs -6.95%
WallTime test_combination_sum[candidates0-8] 12.4 µs 11.6 µs +7.12%
WallTime test_process_creation[ls -l] 6.6 ms 6.8 ms -3.67%
WallTime test_pipe_communication[1000] 6.9 ms 6.7 ms +2.54%
WallTime test_tcp_connection[1.1.1.1-53] 885.5 µs 850.8 µs +4.08%
WallTime test_mmap_operation[409600] 129.5 µs 132.2 µs -2.08%
WallTime test_open_knight_tour[1] 4 µs 4.3 µs -7.06%
WallTime test_hostname_resolution[8.8.8.8] 7.5 µs 7.8 µs -3.95%
WallTime test_make_peak 6.8 µs 6.5 µs +5.31%
WallTime test_sum_of_squares[sum_of_squares_sum_comprehension_product] 192 µs 203.6 µs -5.66%
WallTime test_fs_read[1000] 797.1 ns 828.9 ns -3.83%
WallTime test_multiprocessing_map[10000] 126.5 ms 104.9 ms +20.55%
WallTime test_pipe_communication[10000] 14.9 ms 12.4 ms +19.99%
WallTime test_make_lowpass 6.1 µs 5.6 µs +7.95%
WallTime test_generate_all_combinations[5-4] 10.6 µs 10.2 µs +4.38%
WallTime test_match_word_pattern[aba-GraphTreesGraph] 98.6 µs 106.7 µs -7.61%
WallTime test_iir_filter_process 3.1 µs 3 µs +6.34%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing cod-2202-intermittent-crashes-on-codspeed-macro (1610aa6) with master (c02b664)

Open in CodSpeed

@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review March 27, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent crashes on codspeed-macro

1 participant