Skip to content

feat(i18n): add unused key cleaner#14858

Open
kangfenmao wants to merge 1 commit intov2from
kangfenmao/i18n-unused-clean
Open

feat(i18n): add unused key cleaner#14858
kangfenmao wants to merge 1 commit intov2from
kangfenmao/i18n-unused-clean

Conversation

@kangfenmao
Copy link
Copy Markdown
Collaborator

What this PR does

Before this PR:

Unused i18n keys had to be identified manually or through editor tooling, and there was no repo-level command to safely clean obsolete translation keys across locale files.

After this PR:

Adds pnpm i18n:unused to scan unused i18n keys, report grouped results, optionally output JSON, and clean selected namespaces across locales and translate files. It also supports pnpm i18n:unused --clean --all for explicit non-interactive cleanup of all unused keys. The scanner uses conservative matching rules to avoid deleting keys referenced through dynamic or indirect code paths, including main-process i18n.translation namespace aliases.

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The cleaner is intentionally conservative. Exact key strings and known dynamic patterns are treated as used, which may preserve some truly unused keys but reduces the risk of deleting keys that are still referenced indirectly.

The following alternatives were considered:

Relying only on AST patterns was considered, but it missed valid usages such as key maps, conditional t() arguments, and main-process namespace aliases. A full runtime-aware analysis would be more complex and less practical for this maintenance command.

Links to places where the discussion took place: N/A

Breaking changes

None.

Special notes for your reviewer

This PR also removes the unused keys currently detected by the new scanner after rebasing on v2. The scan result is 0 unused keys after cleanup.

Validated main-process usage such as trayLocale.show_quick_assistant is preserved by alias-aware scanning.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

NONE

Signed-off-by: kangfenmao <kangfenmao@qq.com>
@kangfenmao kangfenmao requested a review from a team May 6, 2026 07:47
@kangfenmao kangfenmao added the v2 label May 6, 2026
Copy link
Copy Markdown
Collaborator

@DeJeune DeJeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants