feat(i18n): add unused key cleaner#14858
Open
kangfenmao wants to merge 1 commit intov2from
Open
Conversation
Signed-off-by: kangfenmao <kangfenmao@qq.com>
ousugo
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
Unused i18n keys had to be identified manually or through editor tooling, and there was no repo-level command to safely clean obsolete translation keys across locale files.
After this PR:
Adds
pnpm i18n:unusedto scan unused i18n keys, report grouped results, optionally output JSON, and clean selected namespaces acrosslocalesandtranslatefiles. It also supportspnpm i18n:unused --clean --allfor explicit non-interactive cleanup of all unused keys. The scanner uses conservative matching rules to avoid deleting keys referenced through dynamic or indirect code paths, including main-processi18n.translationnamespace aliases.Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The cleaner is intentionally conservative. Exact key strings and known dynamic patterns are treated as used, which may preserve some truly unused keys but reduces the risk of deleting keys that are still referenced indirectly.
The following alternatives were considered:
Relying only on AST patterns was considered, but it missed valid usages such as key maps, conditional
t()arguments, and main-process namespace aliases. A full runtime-aware analysis would be more complex and less practical for this maintenance command.Links to places where the discussion took place: N/A
Breaking changes
None.
Special notes for your reviewer
This PR also removes the unused keys currently detected by the new scanner after rebasing on
v2. The scan result is0unused keys after cleanup.Validated main-process usage such as
trayLocale.show_quick_assistantis preserved by alias-aware scanning.Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note