Refactor sample#165
Merged
MartinHjelmare merged 34 commits intodevelopfrom Dec 29, 2019
Merged
Conversation
* Clean up repr. * Add roadmap comment. * Remove not needed well and field names. * Add a leica sample module. * Fix repr. * Add sample and image container base class. * Add container change event. * Fix rename image. * Fix set sample. * Fix gain plugin. * Update sample service. * Hold samples on center. * Fix automation tests. * Move common fixtures. * Fix workflow test.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample state should represent the sample with a representation that is specific to each implemented microscope api using the
ImageContainerapi of camacq. An image container has aname, a dictionary ofimagesand a dictionary ofvaluesas attributes. The container also fires a specific event on container change.There are two special cases of the image container. The first is the main sample container of each microscope api, eg the leica container. The main container has an extra attribute
datawhich is a dictionary with all the containers of the sample. The second special case is the image in the dictionary of images of an image container. The image is also a container and has only itself in the images dictionary and apathattribute with the path of the image.Eg for the leica sample there are plate, well, field, z_slice, channel and image containers under the main leica sample container.
All implemented sample states are available as a variable
samplesin templates in automations. The leica sample is available assamples.leica.See below for the leica sample state attribute structure in camacq. The words in all capital letters are example values. Each image container has a name, which is either of plate, well, field, z_slice, channel or image. The different leica containers have different leica specific attributes that aren't all shown below.