feat(KeyGeneration): Extract keys to inner class "Keys"#2
Closed
ihonliu wants to merge 4 commits intoCatglobe:mainfrom
Closed
feat(KeyGeneration): Extract keys to inner class "Keys"#2ihonliu wants to merge 4 commits intoCatglobe:mainfrom
ihonliu wants to merge 4 commits intoCatglobe:mainfrom
Conversation
Author
|
Seems have some bugs. Close first |
Member
|
Hi @ihonliu. Take a look at release v4 to see if that doesn't solve your issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature description
Add key generation for generating keys in resx files.
Changes
Key Generation Feature:
KeyGenerationproperty toFileOptionsandGlobalOptionsto enable key generation for resource files. (Catglobe.ResXFileCodeGenerator/FileOptions.cs[1]Catglobe.ResXFileCodeGenerator/GlobalOptions.cs[2] [3] [4]StringBuilderGenerator, including methods to create member keys and generate member key strings. (Catglobe.ResXFileCodeGenerator/StringBuilderGenerator.KeyGeneration.cs[1]Catglobe.ResXFileCodeGenerator/StringBuilderGenerator.cs[2] [3]KeyGenerationto the list of compiler-visible properties in the project build configuration. (Catglobe.ResXFileCodeGenerator/build/Catglobe.ResXFileCodeGenerator.props[1] [2]GeneratorTeststo validate the key generation feature. (Catglobe.ResXFileCodeGenerator.Tests/GeneratorTests.cs[1] [2]Project Configuration:
Catglobe.ResXFileCodeGenerator/Catglobe.ResXFileCodeGenerator.csprojCatglobe.ResXFileCodeGenerator/Catglobe.ResXFileCodeGenerator.csprojR22)Minor Fixes:
IsValidLanguageNameutility method to handle null values more safely. (Catglobe.ResXFileCodeGenerator/Utilities.csCatglobe.ResXFileCodeGenerator/Utilities.csL16-R16)