Wrong AbilityId of ActionRawUnitCommand since 94e94ed

[maxnus]

I'm printing an APM report at the end of my game by keeping track of all bot.state.actions during the entire game. Since I updated python-sc2 recently, it has become completely nonsensical.

I think there is a bug introduced in 94e94ed in game_state.py (see 94e94ed#r183392187), where the field ability_id was moved from ActionRawUnitCommand to its base class, AbilityLookupTemplateClass. This changes the argument order of the initializer (before: game_loop, ability_id, ..., after: ability_id, game_loop, ..., but callers, such as game_state.actions have not been updated to the new ordering:

edit: it looks like the same may apply to ActionRawToggleAutocast

[BurnySc2]

I also just started working on it. Thanks for the report, yea it seems I messed that huge refactor up.

I see the PR, but would keyword arguments also work? 3b79ed6

[maxnus]

I also just started working on it. Thanks for the report, yea it seems I messed that huge refactor up.

I see the PR, but would keyword arguments also work? 3b79ed6

Yeah sure, kw are more resilient against breakages like these

[BurnySc2]

I'm almost certain that pyrefly (type checker) should have caught this issue. Interesting that it did not.
I'll merge my change and release a new pypi version.

[maxnus]

I'm almost certain that pyrefly (type checker) should have caught this issue. Interesting that it did not. I'll merge my change and release a new pypi version.

I guess both game_loop and ability_id are int