Skip to content

Initial Markdown prefereces tab#1161

Merged
Rokt33r merged 4 commits intoBoostIO:masterfrom
Komediruzecki:feature/add-markdown-preview-font
Sep 18, 2021
Merged

Initial Markdown prefereces tab#1161
Rokt33r merged 4 commits intoBoostIO:masterfrom
Komediruzecki:feature/add-markdown-preview-font

Conversation

@Komediruzecki
Copy link
Copy Markdown
Contributor

@Komediruzecki Komediruzecki commented Sep 8, 2021

Separate customizable preview and themed based
Add customizable markdown component
Refactor invalid function names regarding theme select

Tested in desktop app
Test preview style changes
Test preview style reset to default
Test change markdown code block theme
Test save new preview style

Showcase:

2021-09-09.22-28-25.mp4

Fixes: https://github.com/Boostnote/BoostHub/issues/1164

@Komediruzecki Komediruzecki force-pushed the feature/add-markdown-preview-font branch 2 times, most recently from ce5c143 to fbef5f0 Compare September 11, 2021 09:44
Copy link
Copy Markdown
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix CR
  • Apply style change with debouncing
  • Change the label of the default button (Default -> Use Default Style)

@Komediruzecki Komediruzecki force-pushed the feature/add-markdown-preview-font branch from 736bd18 to 550a5af Compare September 15, 2021 20:30
@Komediruzecki
Copy link
Copy Markdown
Contributor Author

@Rokt33r Fixed all, also some overflow behavior and styling of preview editors,

New showcase:

2021-09-16.21-48-38.mp4

Separate customizable preview and themed based
Add customizable markdown component
Refactor invalid function names regarding theme select
Move Markdown preferences to Preferences tab
Fix scroll behaviour on Markdown preview in preferences
Fix full width on indent preference
Add debounce instead of save for editing style preview
@Rokt33r Rokt33r force-pushed the feature/add-markdown-preview-font branch from b1855a1 to 6c8cd51 Compare September 18, 2021 10:30
@Rokt33r Rokt33r merged commit 6d0a9a9 into BoostIO:master Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants