A working subset of #1788#1875
Merged
Merged
Conversation
Collaborator
Author
PeterSurda
reviewed
Nov 3, 2021
PeterSurda
reviewed
Nov 3, 2021
PeterSurda
requested changes
Nov 3, 2021
Member
PeterSurda
left a comment
PeterSurda
left a comment
There was a problem hiding this comment.
Mostly ok, just minor cleanup pls.
g1itch
commented
Nov 3, 2021
g1itch
commented
Nov 3, 2021
PeterSurda
requested changes
Nov 4, 2021
Member
PeterSurda
left a comment
PeterSurda
left a comment
There was a problem hiding this comment.
Still encodeBase58(0) is missing. Fixing negative can be fixed either in this PR or a separate one.
Collaborator
Author
It's a simple mechanical fix. I prefer to merge complete tests, not stubs. |
g1itch
force-pushed
the
compat-short
branch
2 times, most recently
from
391228b to
2d14867
Compare
PeterSurda
approved these changes
Nov 11, 2021
varint, protocol.encodeHost(), protocol.CreatePacket() - only checks magic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This is a subset of #1788, the tests that are ready (+4 tests, including those for base58 and varint) and corresponding changes in the
protocolmodule.