Skip to content

Another portion of the formatting and import fixes#1789

Merged
g1itch merged 4 commits into
Bitmessage:v0.6from
g1itch:flake8
Jul 28, 2021
Merged

Another portion of the formatting and import fixes#1789
g1itch merged 4 commits into
Bitmessage:v0.6from
g1itch:flake8

Conversation

@g1itch
Copy link
Copy Markdown
Collaborator

@g1itch g1itch commented Jul 21, 2021

This changeset removes more weird imports, adds more six and addresses some minor lint warnings.

@g1itch g1itch added the formatting Code or UI text formatting label Jul 21, 2021
@g1itch
Copy link
Copy Markdown
Collaborator Author

g1itch commented Jul 26, 2021

Note how most of the compatibility tests pass with this changeset with no need for dirty pasta from #1786:
https://github.com/g1itch/PyBitmessage/runs/3165668219

Only protocol.checkSocksIP() is left: https://github.com/g1itch/PyBitmessage/runs/3166340157

@g1itch g1itch requested a review from PeterSurda July 26, 2021 20:45
Copy link
Copy Markdown
Member

@PeterSurda PeterSurda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

formatting Code or UI text formatting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants