Skip to content

Upgrade to Serilog.Sinks.Http 9.0.0#6

Merged
PetrHeinz merged 2 commits intomainfrom
ph/upgrade-to-http-sink-9
Aug 28, 2024
Merged

Upgrade to Serilog.Sinks.Http 9.0.0#6
PetrHeinz merged 2 commits intomainfrom
ph/upgrade-to-http-sink-9

Conversation

@PetrHeinz
Copy link
Copy Markdown
Member

Resolves #5

This ensures compatibility with the breaking changes in Serilog.Sinks.Http 9.0.0.

I've tried to come up with a solution compatible with both versions, but I couldn't find anything easy to use. I could use reflection, which would make this project harder to understand and maintain with a bit of performance reduction. I could use conditional compilation, but there's no way to detect the used package version, so users would still need to manually switch the version using constants.

In the end, I think just upgrading is a cleaner solution. I would love to get some feedback on this.

@PetrHeinz PetrHeinz requested a review from curusarn August 23, 2024 10:43
@curusarn
Copy link
Copy Markdown

Thanks!

What about people who can't switch to serilog 9?
Is this going to work for them or do they need to pin the version of our library?

@PetrHeinz
Copy link
Copy Markdown
Member Author

PetrHeinz commented Aug 28, 2024

@curusarn People who can't switch to Serilog 9 would see incompatibility error and would be forced to stay with v1.0.0 of our BetterStack.Logs.Serilog.

This is one of the reasons why I suggest bumping version to v1.1.0, so we can release v1.0.x down the road with important patches. Seeing that last change in this repo was 9 months ago, I'm not worried much about it. WDYT?

@curusarn
Copy link
Copy Markdown

curusarn commented Aug 28, 2024

@curusarn People who can't switch to Serilog 9 would see incompatibility error and would be forced to stay with v1.0.0 of our BetterStack.Logs.Serilog.

This is one of the reasons why I suggest bumping version to v1.1.0, so we can release v1.0.x down the road with important patches. Seeing that last change in this repo was 9 months ago, I'm not worried much about it. WDYT?

I'd bump a major version then - i.e. bump to v2.0.0. Wdyt? 🙏

Copy link
Copy Markdown

@curusarn curusarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. But I'd do a major version bump because of breaking backwards compatibility.

@PetrHeinz
Copy link
Copy Markdown
Member Author

After talking it out releasing as minor, as Serilog.Sinks.Http is almost an implementation detail of our package, and switch to higher version doesn't change the user contract of our package.

@PetrHeinz PetrHeinz merged commit 01a1b4d into main Aug 28, 2024
@PetrHeinz PetrHeinz deleted the ph/upgrade-to-http-sink-9 branch August 28, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

serilog-sinks-http 9.0.0 release causes issues on startup

2 participants