Skip to content

Deprecate rmw_qos_profile and ament_target_dependencies() #118

@elsayedelsheikh

Description

@elsayedelsheikh

In ROS2 Kilted, rmw_qos_profile is deprecated

behaviortree_ros2/include/behaviortree_ros2/bt_service_node.hpp:219:57: error: cannot convert ‘const rmw_qos_profile_t’ {aka ‘const rmw_qos_profile_s’} to ‘const rclcpp::QoS&’
    219 |   service_client = node->create_client<T>(service_name, rmw_qos_profile_services_default,
        |                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |                                                         |
        |                                                         const rmw_qos_profile_t {aka const rmw_qos_profile_s}

There's another deprecation warning related to CMake

    ament_target_dependencies() is deprecated.  Use target_link_libraries()
    with modern CMake targets instead.  Try replacing this call with:
  
      target_link_libraries(bool_client PUBLIC
        ${btcpp_ros2_interfaces_TARGETS}
        ${std_msgs_TARGETS}
        ${std_srvs_TARGETS}
        behaviortree_ros2::behaviortree_ros2
        behaviortree_ros2::bt_executor_parameters
      )

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions