Update Taiwan Ethernet phrase mapping to prefer 乙太網路 in s2twp/tw2sp#1181
Open
Update Taiwan Ethernet phrase mapping to prefer 乙太網路 in s2twp/tw2sp#1181
乙太網路 in s2twp/tw2sp#1181Conversation
Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/078fb7ec-32b6-4d82-b634-ce43369a2063 Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update TWPhrasesIT for Ethernet conversions
Update Taiwan Ethernet phrase mapping to prefer May 7, 2026
乙太網路 in s2twp/tw2sp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Taiwan phrase mapping for Ethernet favored
乙太網, while expected user-facing terminology is乙太網路. This PR updates dictionary mappings sos2twpoutputs乙太網路andtw2spcorrectly normalizes both乙太網路and乙太網back to以太网.Dictionary updates (Taiwan phrases)
data/dictionary/TWPhrases.txtto prioritize乙太網路for以太網, while keeping乙太網as an alternate.data/dictionary/TWPhrasesRev.txtto add reverse mapping for乙太網路 -> 以太網and preserve symmetry.Behavior coverage in testcases
test/testcases/testcases.json:s2twp:以太网→乙太網路tw2sp:乙太網路 乙太網→以太网 以太网Mapping change (example)
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
releases.bazel.build/usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 test //data/dictionary:dictionary_test //test:command_line_converter_test(dns block)If you need me to access, download, or install something from one of these locations, you can either: