Skip to content

Update Taiwan Ethernet phrase mapping to prefer 乙太網路 in s2twp/tw2sp#1181

Open
Copilot wants to merge 2 commits intomasterfrom
copilot/update-twphrasesit
Open

Update Taiwan Ethernet phrase mapping to prefer 乙太網路 in s2twp/tw2sp#1181
Copilot wants to merge 2 commits intomasterfrom
copilot/update-twphrasesit

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

The current Taiwan phrase mapping for Ethernet favored 乙太網, while expected user-facing terminology is 乙太網路. This PR updates dictionary mappings so s2twp outputs 乙太網路 and tw2sp correctly normalizes both 乙太網路 and 乙太網 back to 以太网.

  • Dictionary updates (Taiwan phrases)

    • Updated data/dictionary/TWPhrases.txt to prioritize 乙太網路 for 以太網, while keeping 乙太網 as an alternate.
    • Updated data/dictionary/TWPhrasesRev.txt to add reverse mapping for 乙太網路 -> 以太網 and preserve symmetry.
  • Behavior coverage in testcases

    • Added focused cases in test/testcases/testcases.json:
      • s2twp: 以太网乙太網路
      • tw2sp: 乙太網路 乙太網以太网 以太网
  • Mapping change (example)

    # TWPhrases.txt
    以太網    乙太網路 乙太網
    
    # TWPhrasesRev.txt
    乙太網路  以太網
    乙太網    以太網
    

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • releases.bazel.build
    • Triggering command: /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 test //data/dictionary:dictionary_test //test:command_line_converter_test (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue May 7, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Update TWPhrasesIT for Ethernet conversions Update Taiwan Ethernet phrase mapping to prefer 乙太網路 in s2twp/tw2sp May 7, 2026
Copilot AI requested a review from frankslin May 7, 2026 03:24
@frankslin frankslin marked this pull request as ready for review May 7, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

s2twp: 以太网 / 乙太網路

2 participants