Skip to content

Add 门德尔松 → 孟德爾頌 conversion for s2twp#1173

Merged
frankslin merged 3 commits intomasterfrom
copilot/add-mendelssohn-transformation
May 4, 2026
Merged

Add 门德尔松 → 孟德爾頌 conversion for s2twp#1173
frankslin merged 3 commits intomasterfrom
copilot/add-mendelssohn-transformation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 4, 2026

门德尔松 (Simplified variant of Mendelssohn) was not correctly converted to the Taiwan Traditional form 孟德爾頌 under s2twp — it would fall through to character-by-character conversion yielding 門德爾松 instead.

Changes

  • TWPhrases.txt: Add 門德爾松 → 孟德爾頌 so the post-STCharacters form maps to the Taiwan standard
  • TWPhrasesRev.txt: Add symmetric reverse entry 孟德爾頌 → 門德爾松 (required by dictionary symmetry constraint)
  • test/testcases/testcases.json: Add s2twp_mendelssohn and tw2sp_mendelssohn test cases covering both directions

Conversion chain

门德尔松
  → 門德爾松   (STCharacters: 门→門, 尔→爾)
  → 孟德爾頌   (TWPhrases: new entry)

Copilot AI and others added 2 commits May 4, 2026 04:02
@frankslin frankslin merged commit f090c11 into master May 4, 2026
36 of 37 checks passed
@frankslin frankslin deleted the copilot/add-mendelssohn-transformation branch May 4, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants