Skip to content

AoT - Part 3 - Upgrade to Abstractions 11 that are AoT compatible#3699

Merged
bgavrilMS merged 4 commits intomasterfrom
jmprieur/aoT
Feb 5, 2026
Merged

AoT - Part 3 - Upgrade to Abstractions 11 that are AoT compatible#3699
bgavrilMS merged 4 commits intomasterfrom
jmprieur/aoT

Conversation

@jmprieur
Copy link
Copy Markdown
Collaborator

@jmprieur jmprieur commented Feb 3, 2026

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

@jmprieur jmprieur requested a review from a team as a code owner February 3, 2026 21:46
Comment thread src/Microsoft.Identity.Web.Certificate/CertificateDescription.cs
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the repo to Microsoft.Identity.Abstractions v11 and adjusts related code paths to remain compatible with AoT and newer TFMs (including net10), alongside moving the solution to C# 14.

Changes:

  • Bump MicrosoftIdentityAbstractionsVersion to 11.0.0 and set LangVersion to 14.
  • Update logging helpers (block-bodied methods + nullable thumbprint logging) and record the internal API delta in InternalAPI.Unshipped.txt.
  • Adjust certificate handling for net10 via conditional compilation in CertificateDescription.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/Microsoft.Identity.Web.Test/CertificatesObserverTests.cs Tweaks test handler thumbprint comparison to tolerate nulls.
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.Logger.cs Converts logger wrappers to block-bodied methods (AoT-friendly pattern).
src/Microsoft.Identity.Web.TokenAcquisition/PublicAPI/*/InternalAPI.Unshipped.txt Records new internal API signature for nullable cert thumbprint logging across TFMs.
src/Microsoft.Identity.Web.TokenAcquisition/ConfidentialClientApplicationBuilderExtension.cs Passes nullable thumbprint into logging call when selecting certificate credentials.
src/Microsoft.Identity.Web.TokenAcquisition/ConfidentialClientApplicationBuilderExtension.Logger.cs Updates logger wrappers and makes UsingCertThumbprint accept nullable thumbprints.
src/Microsoft.Identity.Web.Certificate/CertificateDescription.cs Conditionalizes Certificate property implementation for NET10_0_OR_GREATER.
Directory.Build.props Moves to C# 14 and upgrades Abstractions dependency version.

Comment thread Directory.Build.props
@jmprieur jmprieur changed the title Upgrade to Abstractions 11 that are AoT compatible AoT - Part 1 - Upgrade to Abstractions 11 that are AoT compatible Feb 4, 2026
@jmprieur jmprieur changed the title AoT - Part 1 - Upgrade to Abstractions 11 that are AoT compatible AoT - Part 3 - Upgrade to Abstractions 11 that are AoT compatible Feb 4, 2026
This was referenced May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants