Antalya 26.3: Fix file identifier in rescheduleTasksFromReplica

[zvonand]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Solved #1486

File identifier for distributed tasks was changed between 25.8 and 26.1
In frontport #1414 it was missed and rescheduleTasksFromReplica continued to use old variant.

Fix unsyncronized access to replica_to_files_to_be_processed class member (#1493 by @ianton-ru).

CI/CD Options

Exclude tests:

• Fast test
• Integration Tests
• Stateless tests
• Stateful tests
• Performance tests
• All with ASAN
• All with TSAN
• All with MSAN
• All with UBSAN
• All with Coverage
• All with Aarch64
• All Regression
• Disable CI Cache

Regression jobs to run:

• Fast suites (mostly <1h)
• Aggregate Functions (2h)
• Alter (1.5h)
• Benchmark (30m)
• ClickHouse Keeper (1h)
• Iceberg (2h)
• LDAP (1h)
• Parquet (1.5h)
• RBAC (1.5h)
• SSL Server (1h)
• S3 (2h)
• S3 Export (2h)
• Swarms (30m)
• Tiered Storage (2h)

Cherry-picked from #1493.

---

Documentation entry for user-facing changes

...

[github-actions]

Workflow [PR], commit [8c42e13]

[alsugiliazova]

Verification report: Altinity/ClickHouse PR #1748

---

Conclusion

PR is merged. CI red on head, but every failure is either a pre-existing flake or a regression-suite scenario already broken at baseline on antalya-26.3. No PR-caused regression found.

Caveat — partial frontport (same as the rest of the 26.3 cohort). Companion antalya-26.1 frontports are still missing on antalya-26.3; chronic regression failures here are branch-level missing-dependency symptoms. Iceberg sort key timezone continues to fail with the same UNRECOGNIZED_ARGUMENTS: '--iceberg_partition_timezone' from a binary that doesn't expose the option.

---

CI on head 8c42e13b — failures

PR test workflow (2 failed checks, 42 success)

Check	Test FAIL	Class
Integration tests (amd_asan, db disk, old analyzer, 5/6)	test_quorum_inserts_parallel::test_parallel_quorum_actually_parallel	Pre-existing flake — 36 / 14 PRs / 90d
Stateless tests (arm_binary, sequential)	00157_cache_dictionary	Pre-existing flake — 106 / 25 PRs / 90d

Regression workflow (10 failed checks)

Check	Top failing tests on PR-1748 builds (30d)	Baseline (antalya-26.3, 30d)	Class
Swarms (Release + Aarch64)	swarm joins / join clause, cluster discovery / multiple paths, node failure / network failure, node failure / cpu overload, swarm join sanity / join with clause (×2 each)	30–44% on every PR	Pre-existing broken
S3Export (partition) (Release + Aarch64)	sanity / no partition by (×2)	50%	Pre-existing broken
Iceberg (1) (Release + Aarch64)	rest catalog / sort key timezone / day transform utc (×2), rest catalog / iceberg iterator race condition (×2)	41% / 28%	Missing-dep + pre-existing flaky
Iceberg (2) (Release + Aarch64)	chronic glue-catalog / race-condition variants	chronic	Pre-existing flaky
Parquet (Release + Aarch64)	postgresql/mysql round-trip compression-type variants (×2 each)	~36%	Pre-existing flaky

Regression DB on /PRs/1748/ builds (30d): 152 Fail / 5,358 OK ≈ 2.8%. Every top failure matches the all-PR baseline fail rate on antalya-26.3. (Numbers are identical to PR #1747 — the two PRs share regression-test runs.)

---

Related to PR diff?

PR is a 2-file fix to the file-identifier handling in rescheduleTasksFromReplica (follow-up to #1747).

Failing test	Diff overlap	Related?
test_parallel_quorum_actually_parallel	none (replicated quorum inserts; unrelated to file-identifier rescheduling on a replica)	No
00157_cache_dictionary	none	No
swarms / *, parquet / *, s3_export_partition / *, iceberg / *	none — none exercise the rescheduleTasksFromReplica path	No

No failing test intersects this PR's code path.

---

Recommendations

1. No action on this PR. Merged and effectively clean.
2. Re-verify after the companion 26.1 → 26.3 frontports land — same list as the prior 26.3 verification reports.
3. Same chronic-baseline cleanup recommendation as VERIFICATION_PR_1640.md for swarms / parquet / s3_export_partition / iceberg scenarios.

---

Local checkout

cd /Users/alsugilyazova/workspace/altinity-clickhouse/ClickHouse
gh pr checkout 1748 --repo Altinity/ClickHouse
# HEAD: 8c42e13b2b9aec8a1fcc84c79ef3a3565074327b

[alsugiliazova]

Audit: PR #1748 — Antalya 26.3: Fix file identifier in rescheduleTasksFromReplica

AI audit note: This review comment was generated by AI (Cursor agent, audit-review skill).

Audit update for PR #1748 (identifier + synchronization)

Confirmed defects

No confirmed defects in reviewed scope.