Replace present_to_schema with macro in examples and docs#35
Open
jmatsushita wants to merge 2 commits intoAlgebraicJulia:mainfrom
Open
Replace present_to_schema with macro in examples and docs#35jmatsushita wants to merge 2 commits intoAlgebraicJulia:mainfrom
jmatsushita wants to merge 2 commits intoAlgebraicJulia:mainfrom
Conversation
jmatsushita
force-pushed
the
fix_examples
branch
from
66f4950 to
b58b7cb
Compare
jmatsushita
force-pushed
the
fix_examples
branch
from
b58b7cb to
9756b9d
Compare
jmatsushita
force-pushed
the
fix_examples
branch
from
de6793d to
9f93f3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
Looking at this test it seems that the way to call
present_to_schemais to use the macro@present_to_schemaexamples/ml_workflow_demo/ml_demo.ipynbexamples/company_demo/concise_demo_ACT.ipynbREADME.mdIt might be possible to write doc tests and use NBInclude.js to tests the notebooks as well (although that might mean either disabling the integration cell which use Postgres, or setting up a more involved testing suite).
Happy to give it a try here if that's of interest or do it in a subsequent PR.
Cheers,
Jun