Stop using auto with * in intuition#496
Conversation
xavierleroy
left a comment
There was a problem hiding this comment.
Thanks for this pull request. I saw the warnings and I know intuition is about to change. Earlier this year, I tried to do fix each call to intuition but didn't go all the way to the end. Your code is nicer because you just change the Tauto.intuition_solver tactic, not each use of intuition. However, Tauto.intuition_solver is not supported in Coq 8.14 and 8.12 (the oldest version supported by CompCert), so I'll probably go back to my approach, with the additional knowledge gained from your code. (I didn't know about the exfalso hint database...)
Also: you left an intuition info_auto with * , I took the liberty to replace it by intuition and it works just fine.
|
There is no rush I think. The warning is enough to avoid inadvertently relying on it in new code, and there are too many users of default intuition in our CI for us to bother porting without a stronger motivation IMO. |
Coq 8.17 warns about this, since at some point in the future `intuition` will become `intuition auto`. This commit rewrites a number of uses of `intuition` to avoid relying on the implicit `intuition auto with *`. Co-authored-by: Gaëtan Gilbert <gaetan.gilbert@skyskimmer.net>
|
Using this PR as a guide, I was able to silence all the 8.17 warnings about |
No description provided.