Explicitly remove __SIZEOF_INT128__ definition.#419
Merged
xavierleroy merged 1 commit intoAbsInt:masterfrom Oct 16, 2021
Merged
Explicitly remove __SIZEOF_INT128__ definition.#419xavierleroy merged 1 commit intoAbsInt:masterfrom
xavierleroy merged 1 commit intoAbsInt:masterfrom
Conversation
Compcert does not support 128-bit integers, but the gcc preprocessor does include support as part of its 'built-in' <https://github.com/gcc-mirror/gcc/blob/ec0124e0acb556cdf5dba0e8d0ca6b69d9537fcc/gcc/c-family/c-cppbuiltin.c#L1558-L1564>. A common way of testing for 128-bit integer support is to check to see if '__SIZEOF_INT128__' is defined. Eliminating this macro prevents software from believing that 128-bit integers are supported.
xavierleroy
approved these changes
Oct 16, 2021
Contributor
xavierleroy
left a comment
xavierleroy
left a comment
There was a problem hiding this comment.
This looks safe and useful. Thanks for the suggestion!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compcert does not support 128-bit integers, but the gcc preprocessor does include support as part of its 'built-in' https://github.com/gcc-mirror/gcc/blob/ec0124e0acb556cdf5dba0e8d0ca6b69d9537fcc/gcc/c-family/c-cppbuiltin.c#L1558-L1564.
A common way of testing for 128-bit integer support is to check to see if 'SIZEOF_INT128' is defined. Eliminating this macro prevents software from believing that 128-bit integers are supported.