Conversation
…ncy graph Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Code Review
This pull request adds a new 'ANcpLua Ecosystem' section to AGENTS.md, providing a detailed overview of the project's repositories, branch protection policies, dependency graph, and release flow. Feedback was provided regarding the branch protection policy, suggesting a requirement of at least one approval for PRs to ensure better code quality. Additionally, several inconsistencies were identified in the CI checks table, specifically concerning versioning terminology, missing NuGet packaging steps, and inconsistent platform coverage across the repositories.
|
|
||
| ### Branch protection (all 4 repos) | ||
|
|
||
| - PR required to merge into `main` (0 approvals, squash preferred) |
There was a problem hiding this comment.
The branch protection policy specifies 0 approvals. This is unusual for a 'protected' branch, as it effectively allows any user with write access to merge their own PRs without peer review. If the intention is to ensure code quality and security through review, this should likely be at least 1 approval. If 0 is intentional (e.g., for a specific automation flow), it might be worth clarifying why it is listed under 'protection'.
| - PR required to merge into `main` (0 approvals, squash preferred) | |
| - PR required to merge into `main` (1 approval, squash preferred) |
| | [ANcpLua.NET.Sdk](https://github.com/ANcpLua/ANcpLua.NET.Sdk) | Opinionated MSBuild SDK — standardized defaults, policy enforcement, analyzer injection | [nuget.org](https://www.nuget.org/packages/ANcpLua.NET.Sdk) | `compute_version`, `lint_config`, `test (ubuntu/windows/macos)`, `create_nuget` | | ||
| | [ANcpLua.Analyzers](https://github.com/ANcpLua/ANcpLua.Analyzers) | Custom Roslyn analyzers (auto-injected by the SDK) | [nuget.org](https://www.nuget.org/packages/ANcpLua.Analyzers) | `build`, `test (ubuntu/windows/macos)` | | ||
| | [ANcpLua.Roslyn.Utilities](https://github.com/ANcpLua/ANcpLua.Roslyn.Utilities) | Source generator utilities, TryParse extensions, polyfills | [nuget.org](https://www.nuget.org/packages/ANcpLua.Roslyn.Utilities) | `build (ubuntu/windows)`, `version` | | ||
| | [ANcpLua.Agents](https://github.com/ANcpLua/ANcpLua.Agents) | MAF runtime helpers + agent test infrastructure | [nuget.org](https://www.nuget.org/packages/ANcpLua.Agents) | `build (ubuntu/windows/macos)`, `version` | |
There was a problem hiding this comment.
The CI checks required column contains several inconsistencies across the ecosystem repositories:
- Versioning:
ANcpLua.NET.Sdkusescompute_version, whileUtilitiesandAgentsuseversion.Analyzersis missing a versioning check entirely. - NuGet Packaging:
create_nugetis only listed for the SDK, despite all four repositories publishing to NuGet. - Platform Coverage:
ANcpLua.Roslyn.Utilitiesis missingmacosin its build matrix, whereas the other repositories include it. - Terminology: There is a mix of
buildandtestlabels.
Standardizing these names and ensuring all required gates (like versioning and package creation) are documented for each repo would improve the clarity of the ecosystem overview.
There was a problem hiding this comment.
Pull request overview
Adds an “ANcpLua Ecosystem” reference section to AGENTS.md to document the related repos, their NuGet packages, CI requirements, branch protection expectations, dependency relationships, and a high-level release flow.
Changes:
- Added an ecosystem table covering 4 repos (purpose, NuGet links, required CI checks).
- Documented shared branch protection rules and a simple dependency graph.
- Added a brief release flow description.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | Repo | Purpose | NuGet | CI checks required | | ||
| |---|---|---|---| | ||
| | [ANcpLua.NET.Sdk](https://github.com/ANcpLua/ANcpLua.NET.Sdk) | Opinionated MSBuild SDK — standardized defaults, policy enforcement, analyzer injection | [nuget.org](https://www.nuget.org/packages/ANcpLua.NET.Sdk) | `compute_version`, `lint_config`, `test (ubuntu/windows/macos)`, `create_nuget` | | ||
| | [ANcpLua.Analyzers](https://github.com/ANcpLua/ANcpLua.Analyzers) | Custom Roslyn analyzers (auto-injected by the SDK) | [nuget.org](https://www.nuget.org/packages/ANcpLua.Analyzers) | `build`, `test (ubuntu/windows/macos)` | | ||
| | [ANcpLua.Roslyn.Utilities](https://github.com/ANcpLua/ANcpLua.Roslyn.Utilities) | Source generator utilities, TryParse extensions, polyfills | [nuget.org](https://www.nuget.org/packages/ANcpLua.Roslyn.Utilities) | `build (ubuntu/windows)`, `version` | | ||
| | [ANcpLua.Agents](https://github.com/ANcpLua/ANcpLua.Agents) | MAF runtime helpers + agent test infrastructure | [nuget.org](https://www.nuget.org/packages/ANcpLua.Agents) | `build (ubuntu/windows/macos)`, `version` | |
| 1. Push to `main` via PR — CI runs, auto-merge bots handle dep bumps | ||
| 2. Tag `vX.Y.Z` on `main` — publish workflow pushes to NuGet | ||
| 3. NuGet indexes in ~4-8 minutes — downstream repos pick up via Renovate |
Adds cross-repo ecosystem reference with NuGet links, required CI checks, branch protection rules, dependency graph, and release flow.