Skip to content

docs(agents): add ecosystem table#91

Merged
ANcpLua merged 1 commit intomainfrom
docs-ecosystem-table
Apr 30, 2026
Merged

docs(agents): add ecosystem table#91
ANcpLua merged 1 commit intomainfrom
docs-ecosystem-table

Conversation

@ANcpLua
Copy link
Copy Markdown
Owner

@ANcpLua ANcpLua commented Apr 30, 2026

Adds cross-repo ecosystem reference with NuGet links, required CI checks, branch protection rules, dependency graph, and release flow.

…ncy graph

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 30, 2026 21:50
@ANcpLua ANcpLua enabled auto-merge (squash) April 30, 2026 21:50
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • AGENTS.md is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9caf4efd-5201-4fb2-aa32-20d0b79f5e43

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new 'ANcpLua Ecosystem' section to AGENTS.md, providing a detailed overview of the project's repositories, branch protection policies, dependency graph, and release flow. Feedback was provided regarding the branch protection policy, suggesting a requirement of at least one approval for PRs to ensure better code quality. Additionally, several inconsistencies were identified in the CI checks table, specifically concerning versioning terminology, missing NuGet packaging steps, and inconsistent platform coverage across the repositories.

Comment thread AGENTS.md

### Branch protection (all 4 repos)

- PR required to merge into `main` (0 approvals, squash preferred)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The branch protection policy specifies 0 approvals. This is unusual for a 'protected' branch, as it effectively allows any user with write access to merge their own PRs without peer review. If the intention is to ensure code quality and security through review, this should likely be at least 1 approval. If 0 is intentional (e.g., for a specific automation flow), it might be worth clarifying why it is listed under 'protection'.

Suggested change
- PR required to merge into `main` (0 approvals, squash preferred)
- PR required to merge into `main` (1 approval, squash preferred)

Comment thread AGENTS.md
Comment on lines +256 to +259
| [ANcpLua.NET.Sdk](https://github.com/ANcpLua/ANcpLua.NET.Sdk) | Opinionated MSBuild SDK — standardized defaults, policy enforcement, analyzer injection | [nuget.org](https://www.nuget.org/packages/ANcpLua.NET.Sdk) | `compute_version`, `lint_config`, `test (ubuntu/windows/macos)`, `create_nuget` |
| [ANcpLua.Analyzers](https://github.com/ANcpLua/ANcpLua.Analyzers) | Custom Roslyn analyzers (auto-injected by the SDK) | [nuget.org](https://www.nuget.org/packages/ANcpLua.Analyzers) | `build`, `test (ubuntu/windows/macos)` |
| [ANcpLua.Roslyn.Utilities](https://github.com/ANcpLua/ANcpLua.Roslyn.Utilities) | Source generator utilities, TryParse extensions, polyfills | [nuget.org](https://www.nuget.org/packages/ANcpLua.Roslyn.Utilities) | `build (ubuntu/windows)`, `version` |
| [ANcpLua.Agents](https://github.com/ANcpLua/ANcpLua.Agents) | MAF runtime helpers + agent test infrastructure | [nuget.org](https://www.nuget.org/packages/ANcpLua.Agents) | `build (ubuntu/windows/macos)`, `version` |
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The CI checks required column contains several inconsistencies across the ecosystem repositories:

  1. Versioning: ANcpLua.NET.Sdk uses compute_version, while Utilities and Agents use version. Analyzers is missing a versioning check entirely.
  2. NuGet Packaging: create_nuget is only listed for the SDK, despite all four repositories publishing to NuGet.
  3. Platform Coverage: ANcpLua.Roslyn.Utilities is missing macos in its build matrix, whereas the other repositories include it.
  4. Terminology: There is a mix of build and test labels.

Standardizing these names and ensuring all required gates (like versioning and package creation) are documented for each repo would improve the clarity of the ecosystem overview.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an “ANcpLua Ecosystem” reference section to AGENTS.md to document the related repos, their NuGet packages, CI requirements, branch protection expectations, dependency relationships, and a high-level release flow.

Changes:

  • Added an ecosystem table covering 4 repos (purpose, NuGet links, required CI checks).
  • Documented shared branch protection rules and a simple dependency graph.
  • Added a brief release flow description.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread AGENTS.md
Comment on lines +254 to +259
| Repo | Purpose | NuGet | CI checks required |
|---|---|---|---|
| [ANcpLua.NET.Sdk](https://github.com/ANcpLua/ANcpLua.NET.Sdk) | Opinionated MSBuild SDK — standardized defaults, policy enforcement, analyzer injection | [nuget.org](https://www.nuget.org/packages/ANcpLua.NET.Sdk) | `compute_version`, `lint_config`, `test (ubuntu/windows/macos)`, `create_nuget` |
| [ANcpLua.Analyzers](https://github.com/ANcpLua/ANcpLua.Analyzers) | Custom Roslyn analyzers (auto-injected by the SDK) | [nuget.org](https://www.nuget.org/packages/ANcpLua.Analyzers) | `build`, `test (ubuntu/windows/macos)` |
| [ANcpLua.Roslyn.Utilities](https://github.com/ANcpLua/ANcpLua.Roslyn.Utilities) | Source generator utilities, TryParse extensions, polyfills | [nuget.org](https://www.nuget.org/packages/ANcpLua.Roslyn.Utilities) | `build (ubuntu/windows)`, `version` |
| [ANcpLua.Agents](https://github.com/ANcpLua/ANcpLua.Agents) | MAF runtime helpers + agent test infrastructure | [nuget.org](https://www.nuget.org/packages/ANcpLua.Agents) | `build (ubuntu/windows/macos)`, `version` |
Comment thread AGENTS.md
Comment on lines +288 to +290
1. Push to `main` via PR — CI runs, auto-merge bots handle dep bumps
2. Tag `vX.Y.Z` on `main` — publish workflow pushes to NuGet
3. NuGet indexes in ~4-8 minutes — downstream repos pick up via Renovate
@ANcpLua ANcpLua merged commit 4a29ee8 into main Apr 30, 2026
25 checks passed
@ANcpLua ANcpLua deleted the docs-ecosystem-table branch April 30, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants