Skip to content

build(deps): bump ANcpLua.Analyzers 1.27.4 → 1.29.0#89

Merged
ANcpLua merged 2 commits intomainfrom
bump-analyzers-1.29.0
Apr 30, 2026
Merged

build(deps): bump ANcpLua.Analyzers 1.27.4 → 1.29.0#89
ANcpLua merged 2 commits intomainfrom
bump-analyzers-1.29.0

Conversation

@ANcpLua
Copy link
Copy Markdown
Owner

@ANcpLua ANcpLua commented Apr 30, 2026

Summary

  • Bump ANcpLua.Analyzers from 1.27.4 → 1.29.0
  • AL0038 (GetOrNull/GetOrDefault suggestion) removed — BCL GetValueOrDefault covers the use case without the dual-overload ambiguity bug

Test plan

  • Version pin change only — no code changes

🤖 Generated with Claude Code

AL0038 (GetOrNull/GetOrDefault suggestion) removed — BCL
GetValueOrDefault covers the use case without the ambiguity bug.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 30, 2026 21:12
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 739f2fcc-92db-4c94-b5fe-dd12e58b89e1

📥 Commits

Reviewing files that changed from the base of the PR and between a3d252f and d05d056.

📒 Files selected for processing (1)
  • src/Build/Common/Version.props

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Summary by CodeRabbit

  • Chores
    • Updated analyzer package version to the latest release to improve overall stability, reliability, and maintenance of the development tooling. This change helps catch issues earlier and contributes to a smoother build and testing experience for the team.

Walkthrough

Updated the ANcpLuaAnalyzersVersion property in src/Build/Common/Version.props from 1.27.4 to 1.29.0. No other properties changed.

Changes

Cohort / File(s) Summary
Build Configuration
src/Build/Common/Version.props
Bumped ANcpLuaAnalyzersVersion from 1.27.4 to 1.29.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

area:infra

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Title check ✅ Passed Title follows conventional commits format with 'build(deps)' prefix, clearly describes the dependency bump, and is 51 characters—well under the 72-character limit.
Description check ✅ Passed Description is directly related to the changeset, documenting the version bump, rationale for the analyzer rule removal, and test plan.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Otel Instrumentation Required ✅ Passed PR updates only a dependency version pin without adding new injectable services, making OpenTelemetry instrumentation verification inapplicable.
No Unbounded Mcp Responses ✅ Passed PR only modifies Version.props to bump ANcpLua.Analyzers; MCP tool directory does not exist and is unmodified.
Duckdb Backpressure On Write Paths ✅ Passed Version pin update to ANcpLuaAnalyzersVersion in build configuration—no new code paths, DuckDB interactions, or write operations.
Cancellationtoken Threading ✅ Passed PR only modifies build configuration file; no new public async methods added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 1/5 review remaining, refill in 45 minutes and 4 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ANcpLuaAnalyzersVersion from 1.27.4 to 1.29.0 in the Version.props file. I have no feedback to provide as there are no review comments.

@ANcpLua ANcpLua merged commit 785074b into main Apr 30, 2026
5 checks passed
@ANcpLua ANcpLua deleted the bump-analyzers-1.29.0 branch April 30, 2026 21:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the centralized analyzer version pin used by the build so the repo consumes ANcpLua.Analyzers v1.29.0.

Changes:

  • Bump ANcpLuaAnalyzersVersion from 1.27.4 to 1.29.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants