feat: Add startupProbe support for all deployment types#297
Open
dnplkndll wants to merge 1 commit into8gears:mainfrom
Open
feat: Add startupProbe support for all deployment types#297dnplkndll wants to merge 1 commit into8gears:mainfrom
dnplkndll wants to merge 1 commit into8gears:mainfrom
Conversation
Kubernetes startupProbe allows slow-starting containers to initialize before liveness/readiness checks begin, preventing premature restarts during startup. This is particularly important for n8n in queue mode where workers need time to connect to Redis/Postgres before becoming healthy. The startupProbe is optional (defaults to empty) and follows the same pattern as the existing livenessProbe and readinessProbe configuration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
WalkthroughThis PR adds conditional startupProbe configurations to the Helm chart for n8n across the main, worker, and webhook container deployments. StartupProbe blocks are added to three deployment templates with corresponding configuration scaffolding in values.yaml, extending existing liveness and readiness probe patterns. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startupProbeconfiguration support for main, worker, and webhook deploymentslivenessProbeandreadinessProbeconfigurationMotivation
Kubernetes
startupProbeallows slow-starting containers to initialize before liveness/readiness checks begin. This is particularly important for n8n in queue mode where workers need time to connect to Redis and Postgres before becoming healthy.Without a startupProbe, the only option is to increase
initialDelaySecondsorfailureThresholdon the liveness probe, which also makes the probe less responsive to actual failures after startup completes.Example usage
Changes
templates/deployment.yaml— addedstartupProbeblock for main containertemplates/deployment.worker.yaml— addedstartupProbeblock for worker containertemplates/deployment.webhook.yaml— addedstartupProbeblock for webhook containervalues.yaml— added documentedstartupProbe: {}defaults for all three sectionsTest plan
helm templaterenders startupProbe correctly when values are providedhelm templaterenders without startupProbe when values are empty (backwards-compatible)Summary by CodeRabbit
Release Notes