feat(core): add human-readable note attr to @slide-comment markers#67
Open
aggradon wants to merge 1 commit into1weiho:mainfrom
Open
feat(core): add human-readable note attr to @slide-comment markers#67aggradon wants to merge 1 commit into1weiho:mainfrom
aggradon wants to merge 1 commit into1weiho:mainfrom
Conversation
Add a `note="..."` attribute to @slide-comment markers so agents and humans can read comments directly from the source file without base64url decoding. The `text` attribute (base64url payload) is preserved for backwards compatibility. - MARKER_RE regex: captures optional note attr group - parseMarkers(): fast path reads note directly, falls back to decode - Marker generation: includes note with JSON-string escaping - DELETE regex: handles new format - Tests: 3 new cases (direct read, special chars, legacy fallback) - Skill: updated regex, procedure, and base64url docs
|
Someone is attempting to deploy a commit to the Yiwei Ho Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every comment added via the inspector is stored as a base64url-encoded payload in the TSX source:
Agents (and humans) cannot read comments at a glance — they must regex-find → base64url-decode → JSON.parse → extract note. Search tools abbreviate the base64url to
eyJub3...zIn0, making the comment invisible. This adds friction to every/apply-commentscycle.Solution
Add a
note="..."attribute with the raw, human-readable text:text(base64url) preserved,noteis optionalJSON.stringifyhandles",\\,*/, etc.Changes
comments-plugin.tsMARKER_REregex,parseMarkers()fast path, marker generation, DELETE regexcomments-plugin.test.tsapply-comments/SKILL.mdTesting
pnpm test— 3 new parseMarkers tests pass