Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up from #17788
This PR enables eslint typechecking when it runs in IDEs as typechecking is slow to be enabled by default. I fiddled with other options, but this seems like the best balance that doesn't affect local DX but still encourages better code written.
With that setup (and the rules added from #17788), I'm able to detect additional places where some regex refactors help improve performance, especially for using
RegExp#execis faster thanString#match.I had previously ran some benchmarks from lukeed/polka#210, which showed that
RegExp#execis consistently faster thanString#match, especially for longer regex or strings.