Conversation
patak-cat
added
p2-nice-to-have
sapphi-red
approved these changes
Nov 29, 2023
Member
sapphi-red
left a comment
sapphi-red
left a comment
There was a problem hiding this comment.
Maybe we should have a test for modern filename -> legacy filename conversion.
Member
Author
|
Let's work on the tests to check the whole thing in another PR. |
patak-cat
deleted the
refactor/legacy-respect-file-names-separators-before-hash
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small followup to:
See comment: #15115 (comment)
Before this PR:
Afterwards
What is the purpose of this pull request?