-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Expand file tree
/
Copy pathFeatureFlagsDialog.tsx
More file actions
231 lines (205 loc) · 7.69 KB
/
FeatureFlagsDialog.tsx
File metadata and controls
231 lines (205 loc) · 7.69 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
import { useFetcher } from "@remix-run/react";
import { useEffect, useState } from "react";
import stableStringify from "json-stable-stringify";
import {
Dialog,
DialogContent,
DialogHeader,
DialogDescription,
DialogFooter,
} from "~/components/primitives/Dialog";
import { Button } from "~/components/primitives/Buttons";
import { Callout } from "~/components/primitives/Callout";
import { cn } from "~/utils/cn";
import { FEATURE_FLAG, type FlagControlType } from "~/v3/featureFlags";
import { UNSET_VALUE, BooleanControl, EnumControl, StringControl } from "./FlagControls";
const HIDDEN_FLAGS = [FEATURE_FLAG.defaultWorkerInstanceGroupId];
type LoaderData = {
org: { id: string; title: string; slug: string };
orgFlags: Record<string, unknown>;
globalFlags: Record<string, unknown>;
controlTypes: Record<string, FlagControlType>;
};
type ActionData = {
success?: boolean;
error?: string;
};
type FeatureFlagsDialogProps = {
orgId: string | null;
orgTitle: string;
open: boolean;
onOpenChange: (open: boolean) => void;
};
export function FeatureFlagsDialog({
orgId,
orgTitle,
open,
onOpenChange,
}: FeatureFlagsDialogProps) {
const loadFetcher = useFetcher<LoaderData>();
const saveFetcher = useFetcher<ActionData>();
const [overrides, setOverrides] = useState<Record<string, unknown>>({});
const [initialOverrides, setInitialOverrides] = useState<Record<string, unknown>>({});
const [saveError, setSaveError] = useState<string | null>(null);
useEffect(() => {
if (open && orgId) {
setSaveError(null);
setOverrides({});
setInitialOverrides({});
loadFetcher.load(`/admin/api/v2/orgs/${orgId}/feature-flags`);
}
}, [open, orgId]);
useEffect(() => {
if (loadFetcher.data) {
const loaded = loadFetcher.data.orgFlags ?? {};
setOverrides({ ...loaded });
setInitialOverrides({ ...loaded });
}
}, [loadFetcher.data]);
useEffect(() => {
if (saveFetcher.data?.success) {
onOpenChange(false);
} else if (saveFetcher.data?.error) {
setSaveError(saveFetcher.data.error);
}
}, [saveFetcher.data]);
const isDirty = stableStringify(overrides) !== stableStringify(initialOverrides);
const setFlagValue = (key: string, value: unknown) => {
setOverrides((prev) => ({ ...prev, [key]: value }));
};
const unsetFlag = (key: string) => {
setOverrides((prev) => {
const next = { ...prev };
delete next[key];
return next;
});
};
const handleSave = () => {
if (!orgId) return;
const body = Object.keys(overrides).length === 0 ? null : overrides;
saveFetcher.submit(JSON.stringify(body), {
method: "POST",
action: `/admin/api/v2/orgs/${orgId}/feature-flags`,
encType: "application/json",
});
};
const data = loadFetcher.data;
const isLoading = loadFetcher.state === "loading";
const isSaving = saveFetcher.state === "submitting";
const jsonPreview =
Object.keys(overrides).length === 0 ? "null" : JSON.stringify(overrides, null, 2);
const sortedFlagKeys = data
? Object.keys(data.controlTypes)
.filter((key) => !HIDDEN_FLAGS.includes(key))
.sort()
: [];
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent className="sm:max-w-lg">
<DialogHeader>Feature flags - {orgTitle}</DialogHeader>
<DialogDescription>
Org-level overrides. Unset flags inherit from global defaults.
</DialogDescription>
<div className="max-h-[60vh] overflow-y-auto">
{isLoading ? (
<div className="py-8 text-center text-sm text-text-dimmed">Loading flags...</div>
) : data ? (
<div className="flex flex-col gap-1.5">
{sortedFlagKeys.map((key) => {
const control = data.controlTypes[key];
const isOverridden = key in overrides;
const globalValue = data.globalFlags[key as keyof typeof data.globalFlags];
const globalDisplay = globalValue !== undefined ? String(globalValue) : "unset";
return (
<div
key={key}
className={cn(
"flex items-center justify-between rounded-md border px-3 py-2.5",
isOverridden
? "border-indigo-500/20 bg-indigo-500/5"
: "border-transparent bg-charcoal-750"
)}
>
<div className="min-w-0 flex-1">
<div
className={cn(
"truncate text-sm",
isOverridden ? "text-text-bright" : "text-text-dimmed"
)}
>
{key}
</div>
<div className="text-xs text-charcoal-400">global: {globalDisplay}</div>
</div>
<div className="flex items-center gap-2">
<Button
variant="minimal/small"
onClick={() => unsetFlag(key)}
className={cn(!isOverridden && "invisible")}
>
unset
</Button>
{control.type === "boolean" && (
<BooleanControl
value={isOverridden ? (overrides[key] as boolean) : undefined}
onChange={(val) => setFlagValue(key, val)}
dimmed={!isOverridden}
/>
)}
{control.type === "enum" && (
<EnumControl
value={isOverridden ? (overrides[key] as string) : undefined}
options={control.options}
onChange={(val) => {
if (val === UNSET_VALUE) {
unsetFlag(key);
} else {
setFlagValue(key, val);
}
}}
dimmed={!isOverridden}
/>
)}
{control.type === "string" && (
<StringControl
value={isOverridden ? (overrides[key] as string) : ""}
onChange={(val) => {
if (val === "") {
unsetFlag(key);
} else {
setFlagValue(key, val);
}
}}
dimmed={!isOverridden}
/>
)}
</div>
</div>
);
})}
</div>
) : null}
</div>
{data && (
<details className="mt-2">
<summary className="cursor-pointer text-xs text-text-dimmed hover:text-text-bright">
Preview JSON
</summary>
<pre className="mt-1 max-h-40 overflow-auto rounded bg-charcoal-800 p-2 text-xs text-text-dimmed">
{jsonPreview}
</pre>
</details>
)}
{saveError && <Callout variant="error">{saveError}</Callout>}
<DialogFooter>
<Button variant="tertiary/small" onClick={() => onOpenChange(false)}>
Cancel
</Button>
<Button variant="primary/small" onClick={handleSave} disabled={!isDirty || isSaving}>
{isSaving ? "Saving..." : "Save changes"}
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
);
}