Skip to content

Commit a7babea

Browse files
authored
chore(Tabs): remove isFocused prop from TabsScreen codegen spec (#3863)
## Description Remove the `isFocused` prop from the `TabsScreen` iOS codegen spec. Tab focus is managed natively by the platform — the JS-driven `isFocused` prop is no longer needed. I believe strongly I've already removed it once, but it returned, likely as some merge / rebase artifact. Closes software-mansion/react-native-screens-labs#1128 ## Changes - Removed `isFocused?: boolean` from `NativeProps` in the codegen spec (`TabsScreenIOSNativeComponent.ts`). - Removed the now-unnecessary `'isFocused'` entry from the `Omit` in `TabRouteOptions` (example app types). > [!note] > The legacy (Paper) arch property remap in `RNSTabsScreenComponentViewManager.mm` is intentionally left untouched — old arch code removal is tracked separately. ## Test plan No new tests — this is a prop removal. Existing Tabs tests should continue to pass as the prop was not actively consumed. ## Checklist - [x] For API changes, updated relevant public types. - [x] Ensured that CI passes
1 parent a821ff0 commit a7babea

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

apps/src/shared/gamma/containers/tabs/TabsContainer.types.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import type { SafeAreaViewProps } from '../../../../../../src/components/safe-ar
1010

1111
export type TabRouteOptions = Omit<
1212
TabsScreenProps,
13-
'children' | 'screenKey' | 'isFocused'
13+
'children' | 'screenKey'
1414
> & {
1515
safeAreaConfiguration?: SafeAreaViewProps;
1616
};

src/fabric/tabs/TabsScreenIOSNativeComponent.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ export interface NativeProps extends ViewProps {
117117
onDidDisappear?: CT.DirectEventHandler<GenericEmptyEvent>;
118118

119119
// Control
120-
isFocused?: boolean;
121120
screenKey: string;
122121
preventNativeSelection?: CT.WithDefault<boolean, false>;
123122

0 commit comments

Comments
 (0)