Remove dead InputBinding.dispose() method (#4375)

* fix: Call InputBinding.dispose() during unbinding (#2875)

InputBinding.dispose() was defined but never called. Now invoked
after unsubscribe and the shiny:unbound event in unbindInputs().
Also fixes the comment that incorrectly said "output" instead of "input".

* Remove InputBinding.dispose() — dead code, never called or documented

Rather than wiring up the never-called dispose(), remove it entirely.
The method was defined but never invoked for 6+ years, is not documented
in the custom input bindings article, and unsubscribe() already serves
as the teardown hook.

* Add NEWS entry for InputBinding.dispose() removal

* Apply suggestion from @cpsievert

* `npm run build` (GitHub Actions)

---------

Co-authored-by: Barret Schloerke <barret@posit.co>
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>

Author: cpsievert

NEWS.md

@@ -15,6 +15,10 @@
 * `conditionalPanel()` no longer briefly flashes its contents on app start
   when the condition is initially `FALSE`. (#3505)
 
+* Removed `InputBinding.dispose()` from the JavaScript `InputBinding` class.
+  This method was never called by Shiny's runtime, so any overrides were dead
+  code. Use `unsubscribe()` for cleanup logic instead. (#4375)
+
 # shiny 1.13.0
 
 ## New features

inst/www/shared/shiny.js

@@ -86,13 +86,6 @@ class InputBinding {
     return;
     el; // eslint-disable-line @typescript-eslint/no-unused-expressions
   }
-
-  // This is called after unbinding the output.
-  dispose(el: HTMLElement): void {
-    //empty
-    return;
-    el; // eslint-disable-line @typescript-eslint/no-unused-expressions
-  }
 }
 
 //// NOTES FOR FUTURE DEV

inst/www/shared/shiny.js.map

@@ -20,7 +20,6 @@ declare class InputBinding {
         delay: number;
     } | null;
     initialize(el: HTMLElement): void;
-    dispose(el: HTMLElement): void;
 }
 export { InputBinding };
 export type { InputSubscribeCallback, SubscribeEventPriority };