Add '--noplugins' tsflag config value

This flag allows the user to disable running of rpm plugins (separately
from libdnf5 plugins), and could help with testing and work around some
troubles installing packages in more complicated build environments.

This is to match adding this option in dnf#2299. I've also removed
documentation that was copied from dnf which didn't seem to be relevant
since this seems to be always compiled against newer librpm which will
have these symbols present.

Parsing of options has had to move because this option affects the
behaviour of rpmtsSetupTransactionPlugins which is called by rpmtsAdd*
functions via rpm_transaction.fill.

Author: jermy

doc/dnf5.conf.5.rst

@@ -594,6 +594,7 @@ repository configuration file should aside from repo ID consists of baseurl, met
     ``nocaps``        ``RPMTRANS_FLAG_NOCAPS``
     ``nocrypto``      ``RPMTRANS_FLAG_NOFILEDIGEST``
     ``deploops``      ``RPMTRANS_FLAG_DEPLOOPS``
+    ``noplugins``     ``RPMTRANS_FLAG_NOPLUGINS``
     ================  ===============================
 
     The ``nocrypto`` option will also set the ``_RPMVSF_NOSIGNATURES`` and
@@ -603,8 +604,7 @@ repository configuration file should aside from repo ID consists of baseurl, met
     It includes downloading of packages, OpenPGP keys check (including permanent import of
     additional keys if necessary), and rpm check to prevent file conflicts.
 
-    The ``nocaps`` is supported with rpm-4.14 or later. When ``nocaps`` is used but rpm
-    doesn't support it, DNF5 only reports it as an invalid tsflag.
+    The ``noplugins`` option disables use of rpm plugins.
 
     Default: empty.
 

libdnf5/base/transaction.cpp

@@ -76,6 +76,7 @@ constexpr std::pair<const char *, rpmtransFlags_e> string_tsflag_map[]{
     {"nocaps", RPMTRANS_FLAG_NOCAPS},
     {"nocrypto", RPMTRANS_FLAG_NOFILEDIGEST},
     {"deploops", RPMTRANS_FLAG_DEPLOOPS},
+    {"noplugins", RPMTRANS_FLAG_NOPLUGINS},
 };
 
 const std::map<base::Transaction::TransactionRunResult, BgettextMessage> TRANSACTION_RUN_RESULT_DICT = {
@@ -947,15 +948,7 @@ Transaction::TransactionRunResult Transaction::Impl::_run(
         return TransactionRunResult::ERROR_LOCK;
     }
 
-    // fill and check the rpm transaction
     libdnf5::rpm::Transaction rpm_transaction(base);
-    rpm_transaction.fill(*transaction);
-    if (!rpm_transaction.check()) {
-        for (auto it : rpm_transaction.get_problems()) {
-            transaction_problems.emplace_back(it.to_string());
-        }
-        return TransactionRunResult::ERROR_CHECK;
-    }
 
     rpmtransFlags rpm_transaction_flags{RPMTRANS_FLAG_NONE};
     for (const auto & tsflag : config.get_tsflags_option().get_value()) {
@@ -978,6 +971,18 @@ Transaction::TransactionRunResult Transaction::Impl::_run(
         }
     }
 
+    // Set flags to ensure "noplugins" option is set before transactions are started
+    rpm_transaction.set_flags(rpm_transaction_flags);
+
+    // fill and check the rpm transaction
+    rpm_transaction.fill(*transaction);
+    if (!rpm_transaction.check()) {
+        for (auto it : rpm_transaction.get_problems()) {
+            transaction_problems.emplace_back(it.to_string());
+        }
+        return TransactionRunResult::ERROR_CHECK;
+    }
+
     // Run rpm transaction test
     rpm_transaction.set_flags(rpm_transaction_flags | RPMTRANS_FLAG_TEST);
     //TODO(jrohel): Do we want callbacks for transaction test?