Skip to content

Fix breaking type definition about typescript#215

Merged
Elyx0 merged 3 commits into
react-native-documents:masterfrom
tkow:feature/for_new_api_type_def
Jul 8, 2019
Merged

Fix breaking type definition about typescript#215
Elyx0 merged 3 commits into
react-native-documents:masterfrom
tkow:feature/for_new_api_type_def

Conversation

@tkow

@tkow tkow commented Jul 7, 2019

Copy link
Copy Markdown
Contributor

Now index.d.ts has many old breaking types.
I fixed,

  • filetype -> type
  • multiple -> disable to inpute

then I add type check test and strict type args by union literal types.

@Elyx0 Elyx0 merged commit 5d74cb5 into react-native-documents:master Jul 8, 2019
@Elyx0

Elyx0 commented Jul 8, 2019

Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants