Skip to content

Commit bcc333c

Browse files
authored
Remove Belt xxxUndefined API (#8377)
1 parent 28a0123 commit bcc333c

119 files changed

Lines changed: 741 additions & 2273 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/@rescript/runtime/Belt_Array.res

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ external getUnsafe: (t<'a>, int) => 'a = "%array_unsafe_get"
1515

1616
external setUnsafe: (t<'a>, int, 'a) => unit = "%array_unsafe_set"
1717

18-
external getUndefined: (t<'a>, int) => Js.undefined<'a> = "%array_unsafe_get"
19-
2018
/* external get: 'a t -> int -> 'a = "%array_safe_get" */
2119
let get = (arr, i) =>
2220
if i >= 0 && i < length(arr) {

packages/@rescript/runtime/Belt_Array.resi

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,6 @@ no bounds checking; this would cause type error if `i` does not stay within rang
5959
*/
6060
external getUnsafe: (t<'a>, int) => 'a = "%array_unsafe_get"
6161

62-
/**
63-
`getUndefined(arr, i)`
64-
65-
It does the samething in the runtime as [`getUnsafe`]();
66-
it is _type safe_ since the return type still track whether it is
67-
in range or not
68-
*/
69-
external getUndefined: (t<'a>, int) => Js.undefined<'a> = "%array_unsafe_get"
70-
7162
/**
7263
`set(arr, n, x)` modifies `arr` in place; it replaces the nth element of `arr`
7364
with `x`. Returning `false` means not updated due to out of range.

packages/@rescript/runtime/Belt_Map.res

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,18 +101,12 @@ let toArray = m => Dict.toArray(m.data)
101101
let keysToArray = m => Dict.keysToArray(m.data)
102102
let valuesToArray = m => Dict.valuesToArray(m.data)
103103
let minKey = m => Dict.minKey(m.data)
104-
let minKeyUndefined = m => Dict.minKeyUndefined(m.data)
105104
let maxKey = m => Dict.maxKey(m.data)
106-
let maxKeyUndefined = m => Dict.maxKeyUndefined(m.data)
107105
let minimum = m => Dict.minimum(m.data)
108-
let minUndefined = m => Dict.minUndefined(m.data)
109106
let maximum = m => Dict.maximum(m.data)
110-
let maxUndefined = m => Dict.maxUndefined(m.data)
111107

112108
let get = (map, x) => Dict.get(~cmp=map.cmp, map.data, x)
113109

114-
let getUndefined = (map, x) => Dict.getUndefined(~cmp=map.cmp, map.data, x)
115-
116110
let getWithDefault = (map, x, def) => Dict.getWithDefault(~cmp=map.cmp, map.data, x, def)
117111

118112
let getOrThrow = (map, x) => Dict.getOrThrow(~cmp=map.cmp, map.data, x)

packages/@rescript/runtime/Belt_Map.resi

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -295,27 +295,15 @@ let valuesToArray: t<'k, 'v, 'id> => array<'v>
295295
/** `minKey(s)` returns the minimum key, None if not exist. */
296296
let minKey: t<'k, _, _> => option<'k>
297297

298-
/** See `Belt.Map.minKey` */
299-
let minKeyUndefined: t<'k, _, _> => Js.undefined<'k>
300-
301298
/** `maxKey(s)` returns the maximum key, None if not exist. */
302299
let maxKey: t<'k, _, _> => option<'k>
303300

304-
/** See `Belt.Map.maxKey` */
305-
let maxKeyUndefined: t<'k, _, _> => Js.undefined<'k>
306-
307301
/** `minimum(s)` returns the minimum key value pair, None if not exist. */
308302
let minimum: t<'k, 'v, _> => option<('k, 'v)>
309303

310-
/** See `Belt.Map.minimum` */
311-
let minUndefined: t<'k, 'v, _> => Js.undefined<('k, 'v)>
312-
313304
/** `maximum(s)` returns the maximum key value pair, None if not exist. */
314305
let maximum: t<'k, 'v, _> => option<('k, 'v)>
315306

316-
/** See `Belt.Map.maximum` */
317-
let maxUndefined: t<'k, 'v, _> => Js.undefined<('k, 'v)>
318-
319307
/**
320308
`get(s, k)`
321309
@@ -334,9 +322,6 @@ Belt.Map.get(Belt.Map.fromArray([(2, "2"), (1, "1"), (3, "3")], ~id=module(IntCm
334322
*/
335323
let get: (t<'k, 'v, 'id>, 'k) => option<'v>
336324

337-
/** See `Belt.Map.get`. Returns `undefined` when not found*/
338-
let getUndefined: (t<'k, 'v, 'id>, 'k) => Js.undefined<'v>
339-
340325
/**
341326
`getWithDefault(s, k, default)`
342327

packages/@rescript/runtime/Belt_MapDict.res

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,7 @@ let minimum = N.minimum
3434
let maximum = N.maximum
3535
let minKey = N.minKey
3636
let maxKey = N.maxKey
37-
let minKeyUndefined = N.minKeyUndefined
38-
let maxKeyUndefined = N.maxKeyUndefined
39-
let minUndefined = N.minUndefined
40-
let maxUndefined = N.maxUndefined
4137
let get = N.get
42-
let getUndefined = N.getUndefined
4338
let getWithDefault = N.getWithDefault
4439
let getOrThrow = N.getOrThrow
4540
let getExn = getOrThrow

packages/@rescript/runtime/Belt_MapDict.resi

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -115,24 +115,14 @@ let valuesToArray: t<'k, 'a, 'id> => array<'a>
115115

116116
let minKey: t<'k, _, _> => option<'k>
117117

118-
let minKeyUndefined: t<'k, _, _> => Js.undefined<'k>
119-
120118
let maxKey: t<'k, _, _> => option<'k>
121119

122-
let maxKeyUndefined: t<'k, _, _> => Js.undefined<'k>
123-
124120
let minimum: t<'k, 'a, _> => option<('k, 'a)>
125121

126-
let minUndefined: t<'k, 'a, _> => Js.undefined<('k, 'a)>
127-
128122
let maximum: t<'k, 'a, _> => option<('k, 'a)>
129123

130-
let maxUndefined: t<'k, 'a, _> => Js.undefined<('k, 'a)>
131-
132124
let get: (t<'k, 'a, 'id>, 'k, ~cmp: cmp<'k, 'id>) => option<'a>
133125

134-
let getUndefined: (t<'k, 'a, 'id>, 'k, ~cmp: cmp<'k, 'id>) => Js.undefined<'a>
135-
136126
let getWithDefault: (t<'k, 'a, 'id>, 'k, 'a, ~cmp: cmp<'k, 'id>) => 'a
137127

138128
let getExn: (t<'k, 'a, 'id>, 'k, ~cmp: cmp<'k, 'id>) => 'a

packages/@rescript/runtime/Belt_MapInt.res

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,9 @@ let isEmpty = N.isEmpty
1111
/* let singleton = N.singleton */
1212

1313
let minKey = N.minKey
14-
let minKeyUndefined = N.minKeyUndefined
1514
let maxKey = N.maxKey
16-
let maxKeyUndefined = N.maxKeyUndefined
1715
let minimum = N.minimum
18-
let minUndefined = N.minUndefined
1916
let maximum = N.maximum
20-
let maxUndefined = N.maxUndefined
2117
let findFirstBy = N.findFirstBy
2218
let forEach = N.forEach
2319
let map = N.map
@@ -169,7 +165,6 @@ let has = I.has
169165
let cmp = I.cmp
170166
let eq = I.eq
171167
let get = I.get
172-
let getUndefined = I.getUndefined
173168
let getWithDefault = I.getWithDefault
174169
let getOrThrow = I.getOrThrow
175170
let getExn = getOrThrow

packages/@rescript/runtime/Belt_MapInt.resi

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -92,24 +92,14 @@ let valuesToArray: t<'v> => array<'v>
9292

9393
let minKey: t<_> => option<key>
9494

95-
let minKeyUndefined: t<_> => Js.undefined<key>
96-
9795
let maxKey: t<_> => option<key>
9896

99-
let maxKeyUndefined: t<_> => Js.undefined<key>
100-
10197
let minimum: t<'v> => option<(key, 'v)>
10298

103-
let minUndefined: t<'v> => Js.undefined<(key, 'v)>
104-
10599
let maximum: t<'v> => option<(key, 'v)>
106100

107-
let maxUndefined: t<'v> => Js.undefined<(key, 'v)>
108-
109101
let get: (t<'v>, key) => option<'v>
110102

111-
let getUndefined: (t<'v>, key) => Js.undefined<'v>
112-
113103
let getWithDefault: (t<'v>, key, 'v) => 'v
114104

115105
let getExn: (t<'v>, key) => 'v

packages/@rescript/runtime/Belt_MapString.res

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,9 @@ let isEmpty = N.isEmpty
1111
/* let singleton = N.singleton */
1212

1313
let minKey = N.minKey
14-
let minKeyUndefined = N.minKeyUndefined
1514
let maxKey = N.maxKey
16-
let maxKeyUndefined = N.maxKeyUndefined
1715
let minimum = N.minimum
18-
let minUndefined = N.minUndefined
1916
let maximum = N.maximum
20-
let maxUndefined = N.maxUndefined
2117
let findFirstBy = N.findFirstBy
2218
let forEach = N.forEach
2319
let map = N.map
@@ -169,7 +165,6 @@ let has = I.has
169165
let cmp = I.cmp
170166
let eq = I.eq
171167
let get = I.get
172-
let getUndefined = I.getUndefined
173168
let getWithDefault = I.getWithDefault
174169
let getOrThrow = I.getOrThrow
175170
let getExn = getOrThrow

packages/@rescript/runtime/Belt_MapString.resi

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -92,24 +92,14 @@ let valuesToArray: t<'v> => array<'v>
9292

9393
let minKey: t<_> => option<key>
9494

95-
let minKeyUndefined: t<_> => Js.undefined<key>
96-
9795
let maxKey: t<_> => option<key>
9896

99-
let maxKeyUndefined: t<_> => Js.undefined<key>
100-
10197
let minimum: t<'v> => option<(key, 'v)>
10298

103-
let minUndefined: t<'v> => Js.undefined<(key, 'v)>
104-
10599
let maximum: t<'v> => option<(key, 'v)>
106100

107-
let maxUndefined: t<'v> => Js.undefined<(key, 'v)>
108-
109101
let get: (t<'v>, key) => option<'v>
110102

111-
let getUndefined: (t<'v>, key) => Js.undefined<'v>
112-
113103
let getWithDefault: (t<'v>, key, 'v) => 'v
114104

115105
let getExn: (t<'v>, key) => 'v

0 commit comments

Comments
 (0)